-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #106250
Closed
Closed
Rollup of 10 pull requests #106250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cargo-miri: use rustc to determine the output filename This should fix rust-lang/miri#2740 and fix rust-lang/miri#1867: we no longer need to hard-code the file name logic in cargo-miri.
handle unknown targets more gracefully In particular don't require a list of all OSes in the TLS machinery. Instead just fall back to doing nothing.
simplify path joining code a bit
support using a JSON target file Fixes rust-lang/miri#2053
This doesn't have an effect, since these tooltip are only one line anyway.
The name makes a lot more sense, and `ty::TyKind` calls it `Ref` already as well.
CraftSpider was removed from the rustdoc team in rust-lang/team#897 and can no longer be assigned.
Instead of ``` LL | fn oom( | __^ | | _| | || LL | || ) { | ||_- LL | | } | |__^ ``` emit ``` LL | // fn oom( LL | || ) { | ||_- LL | | } | |__^ ```
Partly address rust-lang#32059.
…jackh726 Account for multiple multiline spans with empty padding Instead of ``` LL | fn oom( | __^ | | _| | || LL | || ) { | ||_- LL | | } | |__^ ``` emit ``` LL | // fn oom( LL | || ) { | ||_- LL | | } | |__^ ```
…n-err, r=estebank Make trait/impl `where` clause mismatch on region error a bit more actionable Improve `where` clause suggestions for GATs/methods that have incompatible region predicates in their `where` clauses. Also addresses this diagnostic that went away rust-lang#106129 (comment)
Powershell: Use `WaitForExit` instead of `-Wait` Using the method `WaitForExit` instead of the parameter `-Wait` results in a notable speed up of the `x.ps1` script (~350ms, fairly consistently). Results: ``` milliseconds before: 1127.7576 milliseconds after: 779.0467 ``` I think there are opportunities for further speed up by calling `Get-Command` only once with the pattern `py*` then filtering the returned list. But I'll leave that for another time (or someone else). r? `@jyn514`
…, r=GuillaumeGomez rustdoc: remove unnecessary `.tooltip::after { text-align: center }` This doesn't have an effect, since these tooltip are only one line anyway.
…aped-examples, r=notriddle Migrate css var scraped examples r? `@notriddle`
…lly, r=compiler-errors Rename `Rptr` to `Ref` in AST and HIR The name makes a lot more sense, and `ty::TyKind` calls it `Ref` already as well.
…compiler-errors On unsized locals with explicit types suggest `&` Fix rust-lang#72742.
Remove CraftSpider from review rotation CraftSpider was removed from the rustdoc team in rust-lang/team#897 and can no longer be assigned.
update Miri Main PRs: - rust-lang/miri#2741 - rust-lang/miri#2744 This should help quite a bit with Miri support for less common targets. :)
Detect diff markers in the parser Partly address rust-lang#32059.
rustbot
added
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
A-meta
Area: Issues & PRs about the rust-lang/rust repository itself
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Dec 29, 2022
@bors r+ rollup=never p=10 |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 29, 2022
⌛ Testing commit 160544c with merge 9f5b3c330683d2cd99f3ca920cb346ff7908257a... |
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Dec 29, 2022
The job Click to see the possible cause of the failure (guessed by this bot)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-meta
Area: Issues & PRs about the rust-lang/rust repository itself
rollup
A PR which is a rollup
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
where
clause mismatch on region error a bit more actionable #106208 (Make trait/implwhere
clause mismatch on region error a bit more actionable)WaitForExit
instead of-Wait
#106216 (Powershell: UseWaitForExit
instead of-Wait
).tooltip::after { text-align: center }
#106217 (rustdoc: remove unnecessary.tooltip::after { text-align: center }
)Rptr
toRef
in AST and HIR #106221 (RenameRptr
toRef
in AST and HIR)&
#106223 (On unsized locals with explicit types suggest&
)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup