Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add link to Path::join in PathBuf::push #106280

Merged
merged 1 commit into from
Jan 1, 2023
Merged

docs: add link to Path::join in PathBuf::push #106280

merged 1 commit into from
Jan 1, 2023

Conversation

Ezrashaw
Copy link
Contributor

Fixes #106219

Hopefully my wording is alright.

@rustbot
Copy link
Collaborator

rustbot commented Dec 30, 2022

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 30, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 30, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@albertlarsan68
Copy link
Member

I think it is alright

@thomcc
Copy link
Member

thomcc commented Dec 31, 2022

Looks good to me.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 31, 2022

📌 Commit 2c4ecff has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 31, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 31, 2022
@bors
Auto merge of rust-lang#106336 - matthiaskrgr:rollup-4p6bgwf, r=matth…
c9825f7 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#106280 (docs: add link to `Path::join` in `PathBuf::push`)
 - rust-lang#106297 (rustdoc: merge scrape-help CSS)
 - rust-lang#106328 (Add comment explaining what the GUI scrape-examples-fonts test is about)
 - rust-lang#106334 (Fix tidy unittest.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4bf9cae into rust-lang:master Jan 1, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 1, 2023
@bors
Copy link
Contributor

bors commented Jan 1, 2023

⌛ Testing commit 2c4ecff with merge c9825f7...

@Ezrashaw Ezrashaw deleted the path-join-docs-better branch January 1, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

The Path::join method is not very discoverable
5 participants
@Ezrashaw @rustbot @albertlarsan68 @thomcc @bors