Update cargo

[weihanglo]

8 commits in 2381cbdb4e9b07090f552d34a44a529b6e620e44..8c460b2237a6359a7e3335890db8da049bdd62fc
2022-12-23 12:19:27 +0000 to 2023-01-04 14:30:01 +0000

• test: revive nightly plugin tests to work (test: revive nightly plugin tests to work cargo#11534)
• Add note to release notes about rejecting multiple registries. (Add note to release notes about rejecting multiple registries. cargo#11531)
• Fix a typo fresheness -> freshness (Fix a typo fresheness -> freshness cargo#11529)
• Reasons for rebuilding (Reasons for rebuilding cargo#11407)
• Asymmetric tokens (Asymmetric tokens cargo#10771)
• Use proper git URL for GitHub repos (Use proper git URL for GitHub repos cargo#11517)
• Add registry.default example (Add registry.default example cargo#11516)
• Support vendoring with different revs from same git repo (Support vendoring with different revs from same git repo  cargo#10690)

Also update license exceptions and permitted dependencies
for new cargo dependency "pasetors".

A new dependency getrandom is added into rustc-workspace-hacks,
since it requires feature js.

r? @ghost

[rustbot]

Some changes occurred in src/tools/cargo

cc @ehuss

[weihanglo]

@ehuss, please help review this update. I am not quite sure the change of PERMITTED_RUSTC_DEPENDENCIES. Looks like pasetors enables js feature by default.

[ehuss]

Hm, that's unfortunate.

I'm wondering if it would be a good idea to filter out wasm32 from the permitted list? WDYT? I hacked up a solution here: ehuss@a9ec95b

That commit also fixes a bug where it was not removing some extra entries from the permitted list.

I'd like to rope in @Mark-Simulacrum to see if you think it would be reasonable to filter out wasm32 from the tidy permitted dependency list for rustc and cranelift? The idea is to keep the list cleaner by removing dependencies that would never actually be used in rustc.

[weihanglo]

That looks neat to me!

If we need more discussions on a proper fix, should we not block this PR and proceed?

[ehuss]

That's fair. I'll go ahead and approve this, and then follow up with a PR with my proposed change to keep the tidy list tidier.

@bors r+ p=1 rollup=never

[bors]

📌 Commit 323938c34f99801bcd3577e8c8a5816c3b73f9f7 has been approved by ehuss

It is now in the queue for this repository.

[ehuss]

Looks like some issue with bors, it didn't actually get into the queue.

[bors]

⌛ Testing commit 323938c34f99801bcd3577e8c8a5816c3b73f9f7 with merge 6bf7396ed651febcd9e89831eebe23f8e560142d...

[bors]

💔 Test failed - checks-actions

[weihanglo]

Ohh no. Now we need to force everybody to enable features ["wasm-bindgen", "js", "js-sys"] for getrandom. Does this still look good?

[klensy]

Ohh no. Now we need to force everybody to enable features ["wasm-bindgen", "js", "js-sys"] for getrandom. Does this still look good?

Not nice. Why not disable this features in newly introduced dependency (or pr/ask maintainer to do that)?

[ehuss]

Enabling js on getrandom in the workspace-hack seems fine. Those dependencies aren't otherwise built, and it will have no effect.

[weihanglo]

Enabled that with a rebase. Will merge it now.
Feel free to cancel if I did it wrong.

@bors r+ p=1 rollup=never

[bors]

📌 Commit 6306fd3 has been approved by weihanglo

It is now in the queue for this repository.

[bors]

⌛ Testing commit 6306fd3 with merge 659e169...

[bors]

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 659e169 to master...

[rust-timer]

Finished benchmarking commit (659e169): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.2%	[-3.2%, -3.2%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.