Revert "bootstrap: Get rid of tail_args in stream_cargo"

[jyn514]

This reverts commit 9dfe504. (Note: that merged as part of #106305, but #106305 contains more commits than just 9dfe504.)

Fixes x clippy. It turns out clippy was the only one using tail_args 🤦 sorry for not testing this earlier.

r? @Mark-Simulacrum

[jyn514]

The error this fixes:

> x clippy
Checking stage0 library artifacts (aarch64-unknown-linux-gnu -> aarch64-unknown-linux-gnu)
error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `/home/gh-jyn514/.local/lib/rustup/toolchains/nightly-aarch64-unknown-linux-gnu/bin/clippy-driver rustc - --crate-name ___ --print=file-names --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=cfg` (exit status: 1)
  --- stderr
  error: Unrecognized option: 'message-format'

[Mark-Simulacrum]

r=me if we want to fix this, but it's not clear to me why the change didn't work.

[jyn514]

@Mark-Simulacrum check::args is passing -- -Aclippy::xyz for a bunch of lints: https://github.com/rust-lang/rust/blob/6f00f08cfb402f41ca7bc78fb1c0e63100995464/src/bootstrap/check.rs#L53
-- is the separator that tells cargo-clippy to pass the arguments through to clippy-driver instead treating them as cargo arguments.

We might be able to pass those using environment variables instead? But I think it will break caching for std, since RUSTFLAGS applies to dependencies and not just crates in the workspace.

[jyn514]

@bors r=Mark-Simulacrum

[bors]

📌 Commit 6f00f08cfb402f41ca7bc78fb1c0e63100995464 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[Mark-Simulacrum]

Ah, I see. I guess it could get passed via RUSTFLAGS (CLIPPYFLAGS?) in the same way we pass other lint arguments, but this seems fine for now.

The caching does seem hard. Maybe we can always pass clippy flags; doesn't rustc just ignore them?

[jyn514]

No, unfortunately, cargo gives a hard error unless you use cargo rustc instead of cargo check.

; cargo check -- --cap-lints warn
error: Found argument '--cap-lints' which wasn't expected, or isn't valid in this context

Usage: cargo check [OPTIONS]

For more information try '--help'

[jyn514]

Oh, you meant with RUSTFLAGS. Yes, that would work:

; RUSTFLAGS='--cap-lints=warn -Wclippy::too_many_arguments' cargo check
    Checking example v0.1.0 (/home/gh-jyn514/example)
    Finished dev [unoptimized + debuginfo] target(s) in 0.06s

[bors]

☔ The latest upstream changes (presumably #105609) made this pull request unmergeable. Please resolve the merge conflicts.

[jyn514]

Rebased - I haven't reapproved on your behalf in case you want me to use RUSTFLAGS instead of tail_args.

[Mark-Simulacrum]

I'm not worried about doing that as part of this PR.

@bors r+

[bors]

📌 Commit 23d3ee8 has been approved by Mark-Simulacrum

It is now in the queue for this repository.