Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated elaborate box derefs pass #106404

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jan 3, 2023

The pass runs earlier as a part of run_runtime_lowering_passes.

The duplicate was added in #99102.

The pass runs earlier as a part of `run_runtime_lowering_passes`.
@rustbot
Copy link
Collaborator

rustbot commented Jan 3, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 3, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 3, 2023

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@wesleywiser
Copy link
Member

Thanks @tmiasko, good catch!

@bors r+

@bors
Copy link
Contributor

bors commented Jan 3, 2023

📌 Commit 3eabea9 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2023
@wesleywiser
Copy link
Member

r? @wesleywiser

@rustbot rustbot assigned wesleywiser and unassigned TaKO8Ki Jan 3, 2023
@bors
Copy link
Contributor

bors commented Jan 5, 2023

⌛ Testing commit 3eabea9 with merge e94fab6...

@bors
Copy link
Contributor

bors commented Jan 5, 2023

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing e94fab6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 5, 2023
@bors bors merged commit e94fab6 into rust-lang:master Jan 5, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 5, 2023
@tmiasko tmiasko deleted the dedup-box-derefs branch January 5, 2023 12:50
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e94fab6): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.2% [1.2%, 1.2%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.3% [-0.3%, -0.2%] 7
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.7% [-5.5%, -2.5%] 7
Improvements ✅
(secondary)
-2.3% [-4.3%, -0.7%] 61
All ❌✅ (primary) -3.7% [-5.5%, -2.5%] 7

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot added the perf-regression Performance regression. label Jan 5, 2023
@Mark-Simulacrum
Copy link
Member

Single regression is within noise range; improvements are not. Removing perf-regression.

@Mark-Simulacrum Mark-Simulacrum removed the perf-regression Performance regression. label Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants