Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: handle -Zmutable-noalias like -Zbox-noalias #106474

Merged
merged 1 commit into from
Jan 6, 2023
Merged

cleanup: handle -Zmutable-noalias like -Zbox-noalias #106474

merged 1 commit into from
Jan 6, 2023

Conversation

erikdesjardins
Copy link
Contributor

r? @bjorn3

cc @RalfJung this will conflict with #106180

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 5, 2023
@bjorn3
Copy link
Member

bjorn3 commented Jan 5, 2023

Should this wait on #106180 or is it ok to merge this first?

@RalfJung
Copy link
Member

RalfJung commented Jan 5, 2023

I don't think the conflicts will be too bad.

@bors r=bjorn3

@bors
Copy link
Contributor

bors commented Jan 5, 2023

📌 Commit d165a6d has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2023
@bors
Copy link
Contributor

bors commented Jan 6, 2023

⌛ Testing commit d165a6d with merge afe8c45...

@bors
Copy link
Contributor

bors commented Jan 6, 2023

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing afe8c45 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 6, 2023
@bors bors merged commit afe8c45 into rust-lang:master Jan 6, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 6, 2023
@erikdesjardins erikdesjardins deleted the noalias branch January 6, 2023 18:19
@bors bors mentioned this pull request Jan 6, 2023
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (afe8c45): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.6% [-4.6%, -4.6%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 approved these changes

Assignees

@bjorn3 bjorn3

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
6 participants
@erikdesjardins @bjorn3 @RalfJung @bors @rust-timer @rustbot