Detect closures assigned to binding in block #106509
Conversation
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
| @@ -20,6 +20,7 @@ fn bindings() { | |||
| category, | |||
| span, | |||
| &format!("`{}`", name), | |||
| "function", | |||
There was a problem hiding this comment.
Was this change necessary? I'm curious why a rustfmt test needed to change.
There was a problem hiding this comment.
I added a new argument in rustc. The rustfmt change is just to keep compatibility.
There was a problem hiding this comment.
@ytmimi - Technically I don't think it's necessary because we never need to compile these files, but I don't think the extra arg impacts the integrity of the rustfmt test in any way (I assumed it was simply changed based on a find+replace using the ident)
There was a problem hiding this comment.
Yeah, I blanket searched for all the function calls.
|
@bors r+ |
bors
added
S-waiting-on-bors
…twco Detect closures assigned to binding in block Fix rust-lang#58497.
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#101936 (Migrating rustc_infer to session diagnostics (part 3)) - rust-lang#104081 (PhantomData layout guarantees) - rust-lang#104543 (Migrate `codegen_ssa` to diagnostics structs - [Part 3]) - rust-lang#105128 (Add O(1) `Vec -> VecDeque` conversion guarantee) - rust-lang#105517 (Fix process-panic-after-fork.rs to pass on newer versions of Android.) - rust-lang#105859 (Point out span where we could introduce higher-ranked lifetime) - rust-lang#106509 (Detect closures assigned to binding in block) - rust-lang#106553 (docs: make `HashSet::retain` doctest more clear) - rust-lang#106556 (rustdoc: remove no-op mobile CSS `.content { margin-left: 0 }`) - rust-lang#106564 (Change to immutable borrow when cloning element of RepeatN) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fix #58497.