Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustc infer doctest #106523

Closed
wants to merge 3 commits into from
Closed

Conversation

CarsonV
Copy link
Contributor

@CarsonV CarsonV commented Jan 6, 2023

More efforts towards #99144. Made some assumptions as I was going along but wanted to get eyes on them now so I can learn before moving on towards completing the rest of the missing doctests.

@rustbot
Copy link
Collaborator

rustbot commented Jan 6, 2023

r? @estebank

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 6, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 6, 2023

Some changes occurred in need_type_info.rs

cc @lcnr

@CarsonV
Copy link
Contributor Author

CarsonV commented Jan 6, 2023

r? jyn514

@rustbot rustbot assigned jyn514 and unassigned estebank Jan 6, 2023
@CarsonV
Copy link
Contributor Author

CarsonV commented Jan 6, 2023

@rustbot label: +A-testsuite

@rustbot rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jan 6, 2023
@jyn514
Copy link
Member

jyn514 commented Jan 24, 2023

Sorry for the long wait. I won't have time for reviews for the foreseeable future.

As a note, this has many of the changes from #106574.

r? @Nilstrieb

@rustbot rustbot assigned Noratrieb and unassigned jyn514 Jan 24, 2023
Comment on lines 289 to 293
/// It will not, however, work for higher-ranked bounds like:
///
/// ```compile_fail,E0311
/// ```
/// trait Foo<'a, 'b>
/// where for<'x> <Self as Foo<'x, 'b>>::Bar: 'x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs say that this shouldn't compile, so there's something wrong here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you need any help with figuring this out, feel free to open a thread in the t-compiler/help stream on zulip

@Noratrieb Noratrieb added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2023
@Dylan-DPC
Copy link
Member

@CarsonV any updates on this?

@CarsonV
Copy link
Contributor Author

CarsonV commented Mar 8, 2023

@Dylan-DPC I got busy/ was partially waiting to see if the duplicate work was finished faster than I could. I missed the response from jyn and Nilstrieb with feedback. Sorry about that! Did not mean to waste everyone's time. I will get back into this tonight or tomorrow night

@bors
Copy link
Contributor

bors commented May 8, 2023

☔ The latest upstream changes (presumably #106621) made this pull request unmergeable. Please resolve the merge conflicts.

@Noratrieb
Copy link
Member

This was subsumed by #106486, closing it. Thank you for the PR anyways!

@Noratrieb Noratrieb closed this May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants