Rollup of 10 pull requests #106654
Closed
Rollup of 10 pull requests #106654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is ambiguous whether this should produce several `.span_suggestions()` calls or one `.multipart_suggestions()` call.
The check previously matched this, and suggested adding a missing `struct`: pub Foo(...): It was probably intended to match this instead (semicolon instead of colon): pub Foo(...);
This is required in order to support translatable diagnostics.
#[derive(Subdiagnostic)] does not allow multiple subdiagnostics on one variant, as in NonItemInItemListSub::Other.
Because the old spelling is widely used, some projects may need time to migrate their uses to the new triple spelling. The old spelling may eventually be removed altogether.
…flatten_doc, r=cuviper Add example for iterator_flatten Adds an Example to iterator_flatten Fixes rust-lang#82687
… r=davidtwco rustc_parse: diagnostics migration, v4 This is all the `rustc_parse` migrations I have in store right now; unfortunately life is pretty busy right now, so I won't be able to do much more in the near future. cc rust-lang#100717 r? `@davidtwco`
…agisa Enable atomic cas for bpf targets It seems like LLVM now supports it. https://reviews.llvm.org/D72184 - the PR in LLVM
…=oli-obk Fix bad import suggestion with nested `use` tree Fixes rust-lang#105566 Fixes rust-lang#105373 Ideally, we'd find some way to turn these into structured suggestions -- perhaps on a separate line as a different `use` statement, but I have no idea how to access the span for the whole `use` from this point in the import resolution code.
…-compare, r=oli-obk No need to take opaques in `check_type_bounds` `InferCtxt` already has its defining use anchor set to err r? `@oli-obk`
…didates, r=oli-obk Prefer non-`[type error]` candidates during selection Fixes rust-lang#102130 Fixes rust-lang#106351 r? types note: Alternatively we could filter out error where-clauses during param-env construction? But we still need to filter out impls with errors during `match_impl`, I think.
…erbose, r=estebank Render missing generics suggestion verbosely It's a bit easier to read like this, especially ones that are appending new generics onto an existing list, like ": `, T`" which render somewhat poorly inline. Also don't suggest `dyn` as a type parameter to add, even if technically that's valid in edition 2015.
…e, r=tmandry Accept old spelling of Fuchsia target triples The old spelling of Fuchsia target triples was changed in rust-lang#106429 to add a proper vendor. Because the old spelling is widely used, some projects may need time to migrate their uses to the new triple spelling. The old spelling may eventually be removed altogether. r? `@tmandry`
update test for inductive canonical cycles the previous test always resulted in a cycle 😅 cc rust-lang/chalk#787. I checked with rust-lang#102713 and this is the only test which fails with that PR. r? `@jackh726`
…Gomez rustdoc: merge common CSS for `a`
rustbot
added
A-translation
|
@bors r+ rollup=never p=10 |
bors
added
S-waiting-on-bors
|
@bors r- |
bors
added
S-waiting-on-author
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
usetree #106175 (Fix bad import suggestion with nestedusetree)check_type_bounds#106204 (No need to take opaques incheck_type_bounds)[type error]candidates during selection #106309 (Prefer non-[type error]candidates during selection)a#106647 (rustdoc: merge common CSS fora)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup