Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Opaque/Projection handling in region outlives code #106829

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Unify Opaque/Projection handling in region outlives code #106829

merged 1 commit into from
Jan 17, 2023

Conversation

compiler-errors
Copy link
Member

They share basically identical paths in most places which are even easier to unify now that they're both ty::Alias

r? types

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 13, 2023
@compiler-errors compiler-errors mentioned this pull request Jan 15, 2023
Merged
@spastorino
Copy link
Member

Looks good to be but I have a question. You mentioned "now that they're both ty::Alias", I guess this is talking about a change that I may have miss. Can you point out to what are you referring to?.

@compiler-errors
Copy link
Member Author

It's #104986 which combines those two into one alias type

@spastorino
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 16, 2023

📌 Commit 1ea6862 has been approved by spastorino

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2023
@bors
Auto merge of rust-lang#106966 - matthiaskrgr:rollup-e34pevi, r=matth…
85357e3 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#106591 (suggestion for attempted integer identifier in patterns)
 - rust-lang#106712 (make error emitted on `impl &Trait` nicer)
 - rust-lang#106829 (Unify `Opaque`/`Projection` handling in region outlives code)
 - rust-lang#106869 (rustdoc: remove redundant item kind class from `.item-decl > pre`)
 - rust-lang#106949 (ConstBlocks are poly if their substs are poly)
 - rust-lang#106953 (Document `EarlyBinder::subst_identity` and `skip_binder`)
 - rust-lang#106958 (Don't add A-bootstrap to PRs modifying Cargo.lock)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6b49435 into rust-lang:master Jan 17, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 17, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2023
@bors
Auto merge of rust-lang#106910 - aliemjay:alias-ty-in-regionck, r=oli…
19423b5 
…-obk

even more unify Projection/Opaque handling in region outlives code

edit: This continues ate the same pace as rust-lang#106829. New changes are described in rust-lang#106910 (comment).

~This touches `OutlivesBound`, `Component`, `GenericKind` enums.~

r? `@oli-obk` (because of overlap with rust-lang#95474)
@compiler-errors compiler-errors deleted the more-alias-combine branch August 11, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spastorino spastorino

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
4 participants
@compiler-errors @spastorino @bors @rustbot