-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Fix glob import inlining #106952
Conversation
Filter away names that are not actually imported by the glob, e.g. because they are shadowed by something else
r? @notriddle (rustbot has picked a reviewer for you, use r? to override) |
Looks good to me, thanks! r=me once CI pass |
Looks like a reasonable fix. It might have a perf impact, so: @bors r=notriddle,GuillaumeGomez rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (aaa9bb9): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
Filter away names that are not actually imported by the glob, e.g. because they are shadowed by something else.
Fixes the issue found in #94857 (comment).