Intern CanonicalVarValues

[compiler-errors]

So that they are copy ✨

[rustbot]

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

[compiler-errors]

@bors try @rust-timer queue

[rustbot]

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

[bors]

⌛ Trying commit 850c79c6f75a858bcdedd0cac6bde769047ba465 with merge 2777437a69027d396b7496e1eecb26b36b9111a5...

[bors]

☀️ Try build successful - checks-actions
Build commit: 2777437a69027d396b7496e1eecb26b36b9111a5 (2777437a69027d396b7496e1eecb26b36b9111a5)

[rust-timer]

Finished benchmarking commit (2777437a69027d396b7496e1eecb26b36b9111a5): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[1.3%, 3.2%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

[compiler-errors]

Wonderful

[lcnr]

🤔 this could just be CanonicalVarValues::make_identity? should replace it

[compiler-errors]

But we don't have a CanonicalVarValues here, we have a CanonicalVarInfos, so we can't call make_identity?

[compiler-errors]

Actually, there are no call-sites for make_identity anymore 🤔

I'll just make it take CanonicalVarInfos

[lcnr]

r=me after nit ❤️

[compiler-errors]

@bors r=lcnr

nit addressed

[bors]

📌 Commit 2d5591d has been approved by lcnr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 2d5591d with merge 1e22541...

[bors]

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 1e22541 to master...

[rust-timer]

Finished benchmarking commit (1e22541): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.8%	[2.8%, 2.8%]	1
Regressions ❌ (secondary)	3.6%	[2.7%, 4.5%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.8%	[-2.5%, -1.1%]	3
All ❌✅ (primary)	2.8%	[2.8%, 2.8%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-3.0%, -2.3%]	3
All ❌✅ (primary)	-	-	0