-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #107309
Rollup of 9 pull requests #107309
Conversation
Suggest using a lock instead.
They were missing after recent move from src/test to tests.
This patch avoids hard-to-click single character links by making the generic part of the link: Before: <a href="#">&</a>T After: <a href="#">&T</a>
…ckh726 Add hint for missing lifetime bound on trait object when type alias is used Fix issue rust-lang#103582. The problem: When a type alias is used to specify the return type of the method in a trait impl, the suggestion for fixing the problem of "missing lifetime bound on trait object" of the trait impl will not be created. The issue caused by the code which searches for the return trait objects when constructing the hint suggestion is not able to find the trait objects since they are specified in the type alias path instead of the return path of the trait impl. The solution: Trace the trait objects in the type alias path and provide them along with the alias span to generate the suggestion in case the type alias is used in return type of the method in the trait impl.
…tic, r=WaffleLapkin Suggest using a lock for `*Cell: Sync` bounds I mostly did this for `OnceCell<T>` at first because users will be confused to see that the `OnceCell<T>` in `std` isn't `Sync` but then extended it to `Cell<T>` and `RefCell<T>` as well.
Bring tests back into rustc source tarball They were missing after recent move from src/test to tests. cc ```@albertlarsan68``` Fixes rust-lang#107081
…rence-link, r=GuillaumeGomez rustdoc: rearrange HTML in primitive reference links This patch avoids hard-to-click single character links by making the generic part of the link: Before: <a href="#">&</a>T After: <a href="#">&T</a>
add test where we ignore hr implied bounds r? types
Delete `SimplifyArmIdentity` and `SimplifyBranchSame` mir opts I had attempted to fix the first of these opts in rust-lang#94177 . However, despite that PR already being a full re-write, it still did not fix some of the core soundness issues. The optimizations that are attempted here are likely to be desirable, but I do not expect any of the currently written code to survive into a sound implementation. Deleting the code keeps us from having to maintain the passes in the meantime. Closes rust-lang#77359 , closes rust-lang#72800 , closes rust-lang#78628 r? ```@cjgillot```
…=notriddle rustdoc: prohibit scroll bar on source viewer in Safari Fixes rust-lang#106455.
…s, r=compiler-errors erica solver: implement builtin `Pointee` trait impl candidates r? ```@compiler-errors```
@bors r+ rollup=never p=9 |
I thought #107244 made the previous rollup fail? (#107244 (comment)) |
So did I, but it turned out to be #107284 🙃 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR: previous master: c18a5e8a5b In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (2a17174): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Successful merges:
*Cell: Sync
bounds #106944 (Suggest using a lock for*Cell: Sync
bounds)SimplifyArmIdentity
andSimplifyBranchSame
mir opts #107256 (DeleteSimplifyArmIdentity
andSimplifyBranchSame
mir opts)Pointee
trait impl candidates #107282 (erica solver: implement builtinPointee
trait impl candidates)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup