-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 13 pull requests #107530
Closed
Closed
Rollup of 13 pull requests #107530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Existing compilers link to the md version * The YAML version field for the backtrace *doesn't let us paste a full backtrace* * We will need the YAML version in order to be able to submit reports once we start storing the backtrace to disk
Version 4.005 was released on 2023-01-20.
These rules were needed for the mobile-style switches, but those were removed in 0f3ae62
Based on a couple of sources: - https://swatinem.de/blog/future-size/ - rust-lang#62958
… r=Mark-Simulacrum Include both md and yaml ICE ticket templates * Existing compilers link to the md version * The YAML version field for the backtrace *doesn't let us paste a full backtrace* * We will need the YAML version in order to be able to submit reports once we start storing the backtrace to disk Follow up to rust-lang#106831. Reaction to rust-lang#106874, which made me realize that *really* long backtraces are rejected by GitHub Forms. A single backtrace won't hit this, but ICEs sometimes compound.
…ddle Clean up eslint annotations and remove unused JS function Thanks to rust-lang#107177 I realized that some eslint annotations might be unneeded so I cleaned them up. I also removed the unused function while we wait for rust-lang#107177 to be updated. r? `@notriddle`
…-errors small refactor to new projection code extract `eq_term_and_make_canonical_response` into a helper function which also is another guarantee that the expected term does not influence candidate selection for projections. also change `evaluate_all(vec![single_goal])` to use `evaluate_goal`. the second commit now also adds a `debug_assert!` to `evaluate_goal`.
…llaumeGomez rustdoc: update Source Serif 4 from 4.004 to 4.005 [Version 4.005](https://github.com/adobe-fonts/source-serif/releases/tag/4.005R) was released on 2023-01-20.
…iser avoid needless checks
Improve enum checks Some light refactoring.
…, r=oli-obk Track bound types like bound regions When we instantiate bound types into placeholder types, we throw away the names for some reason. These names are particularly useful for error reporting once we have `for<T>` binders. r? types
…nd-2, r=estebank Make the "extra if in let...else block" hint a suggestion Changes the hint to a suggestion, suggested in rust-lang#107213. r? ``@estebank``
… r=GuillaumeGomez rustdoc: remove unused CSS from `.setting-check` These rules were needed for the mobile-style switches, but those were removed in 0f3ae62
…est, r=compiler-errors Add tests to assert current behavior of large future sizes Based on a couple of sources: - https://swatinem.de/blog/future-size/ - rust-lang#62958
`Edition` micro refactor r? `@oli-obk`
PointeeInfo is advisory only rust-lang#107248 fixed PointeeInfo being used in ways that don't actually work. Hopefully this comments helps avoid such issues in the future. Cc `@eddyb`
…r=GuillaumeGomez rustdoc: stop making unstable items transparent Fixes rust-lang#93393
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
WG-trait-system-refactor
The Rustc Trait System Refactor Initiative (-Znext-solver)
rollup
A PR which is a rollup
labels
Jan 31, 2023
@bors r+ p=8 rollup=never |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 31, 2023
⌛ Testing commit 382aff1 with merge 8817b8f87054a4e5b9f4cd01439cfb9eda71d95f... |
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Jan 31, 2023
The job Click to see the possible cause of the failure (guessed by this bot)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rollup
A PR which is a rollup
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
WG-trait-system-refactor
The Rustc Trait System Refactor Initiative (-Znext-solver)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
.setting-check
#107491 (rustdoc: remove unused CSS from.setting-check
)Edition
micro refactor #107508 (Edition
micro refactor)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup