Commits on Feb 16, 2023

1. Default repr(C) enums to c_int size …

   This is what ISO C strongly implies this is correct, and
   many processor-specific ABIs imply or mandate this size, so
   "everyone" (LLVM, gcc...) defaults to emitting enums this way.
   However, this is by no means guaranteed by ISO C,
   and the bare-metal Arm targets show it can be overridden,
   which rustc supports via `c-enum-min-bits` in a target.json.
   
   The override is a flag named `-fshort-enums` in clang and gcc,
   but introducing a CLI flag is probably unnecessary for rustc.
   This flag can be used by non-Arm microcontroller targets,
   like AVR and MSP430, but it is not enabled for them by default.
   Rust programmers who know the size of a target's enums
   can use explicit reprs, which also lets them match C23 code.
   
   This change is most relevant to 16-bit targets: AVR and MSP430.
   Most of rustc's targets use 32-bit ints, but ILP64 does exist.
   Regardless, rustc should now correctly handle enums for
   both very small and very large targets.
   
   Thanks to William for confirming MSP430 behavior,
   and to Waffle for better style and no-core size_of asserts.
   
   Co-authored-by: William D. Jones <thor0505@comcast.net>
   Co-authored-by: Waffle Maybe <waffle.lapkin@gmail.com>

   

   3 people committed Feb 16, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 2edf6c8
   • Browse repository at this point

   Copy the full SHA

   2edf6c8 View commit details

   Browse the repository at this point in the history