loudly tell people when they change Cargo.lock
#107631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-meta
BoxyUwU
force-pushed
the
triagebot_cargo_lock
branch
from
7d43e0e
to
b83078f
Compare
|
The pre-push hook does now fail if the lock file needs to be updated. |
|
I don't think thats sufficient unless "now" means literally now, for example #107603 was submitted in the last 24hrs and has this issue 😅 |
|
Since #107169 was merged, but they need to install the pre-push hook. |
|
I think this is fine to land as a stop-gap -- it's not too heavyweight of a ping on a PR, and those who know what they're doing (e.g. actually touching @bors r+ rollup |
This comment was marked as duplicate.
This comment was marked as duplicate.
bors
added
S-waiting-on-bors
This comment was marked as duplicate.
This comment was marked as duplicate.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 3, 2023
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#106887 (Make const/fn return params more suggestable) - rust-lang#107519 (Add type alias for raw OS errors) - rust-lang#107551 ( Replace `ConstFnMutClosure` with const closures ) - rust-lang#107595 (Retry opening proc-macro DLLs a few times on Windows.) - rust-lang#107615 (Replace nbsp in all rustdoc code blocks) - rust-lang#107621 (Intern external constraints in new solver) - rust-lang#107631 (loudly tell people when they change `Cargo.lock`) - rust-lang#107632 (Clarifying that .map() returns None if None.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It keeps happening that people accidentally commit changes to
Cargo.lockand then have to be told by a reviewer to undo this. I've also seen cases where PRs are merged that accidentally changedCargo.lockduring a rebase.. I figure that purposeful changes toCargo.lockare likely rarer than these accidental ones?