Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for overflow in evaluate_canonical_goal #107739

Merged

Conversation

spastorino
Copy link
Member

r? @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Feb 6, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2023

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@spastorino spastorino force-pushed the check-overflow-evaluate_canonical_goal branch from 30ae0b0 to f6b0355 Compare February 6, 2023 20:38
@spastorino spastorino changed the title Check overflow evaluate canonical goal Check for overflow in evaluate_canonical_goal Feb 7, 2023
@spastorino spastorino force-pushed the check-overflow-evaluate_canonical_goal branch from f6b0355 to 74047f4 Compare February 9, 2023 14:52
@spastorino
Copy link
Member Author

@lcnr applied the suggested changes, let me know if that was what you had in mind.

@spastorino spastorino force-pushed the check-overflow-evaluate_canonical_goal branch from 74047f4 to 65ccaa5 Compare February 13, 2023 17:41
@spastorino spastorino force-pushed the check-overflow-evaluate_canonical_goal branch from 65ccaa5 to fba04cc Compare February 13, 2023 17:45
@rust-log-analyzer

This comment has been minimized.

@spastorino spastorino force-pushed the check-overflow-evaluate_canonical_goal branch from fba04cc to a4c5746 Compare February 13, 2023 20:04
@spastorino spastorino force-pushed the check-overflow-evaluate_canonical_goal branch from a4c5746 to c8dae10 Compare February 14, 2023 12:51
@spastorino spastorino force-pushed the check-overflow-evaluate_canonical_goal branch from bae6e20 to 26136c6 Compare February 14, 2023 13:17
@lcnr
Copy link
Contributor

lcnr commented Feb 14, 2023

@bors r+ rollup (only new solver)

@lcnr lcnr closed this Feb 14, 2023
@bors
Copy link
Contributor

bors commented Feb 14, 2023

📌 Commit 26136c6 has been approved by lcnr

It is now in the queue for this repository.

@lcnr lcnr reopened this Feb 14, 2023
@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 14, 2023
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 14, 2023
@lcnr
Copy link
Contributor

lcnr commented Feb 14, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 14, 2023

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Feb 14, 2023

📌 Commit 26136c6 has been approved by lcnr

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 14, 2023
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#103478 ( Suggest fix for misplaced generic params on fn item rust-lang#103366 )
 - rust-lang#107739 (Check for overflow in evaluate_canonical_goal)
 - rust-lang#108003 (Avoid ICE when the generic_span is empty)
 - rust-lang#108016 ("Basic usage" is redundant for there is just one example)
 - rust-lang#108023 (Shrink size of array benchmarks)
 - rust-lang#108024 (add message to update Cargo.toml when x is changed)
 - rust-lang#108025 (rustdoc: add more tooltips to intra-doc links)
 - rust-lang#108029 (s/eval_usize/eval_target_usize/ for clarity)
 - rust-lang#108035 (Avoid using a dead email address as the main email address)
 - rust-lang#108038 (Remove needless supertrait constraints from Interner projections)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9ee3c7a into rust-lang:master Feb 14, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants