Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: simplify DOM for .item-table #107783

Merged
merged 1 commit into from
Feb 19, 2023
Merged

rustdoc: simplify DOM for .item-table #107783

merged 1 commit into from
Feb 19, 2023

Conversation

notriddle
Copy link
Contributor

This switches from using <div> to the more semantic <ul>, and using class names that rhyme with the classes the search results table uses.

@notriddle
rustdoc: simplify DOM for .item-table
894c986 
This switches from using `<div>` to the more semantic `<ul>`, and
using class names that rhyme with the classes the search results
table uses.
@rustbot
Copy link
Collaborator

rustbot commented Feb 8, 2023

r? @jsha

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 8, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 8, 2023

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@notriddle
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 8, 2023
@bors
Copy link
Contributor

bors commented Feb 8, 2023

⌛ Trying commit 894c986 with merge fe246d4bdf58a842787875da6815f4d4e44c4e92...

@bors
Copy link
Contributor

bors commented Feb 8, 2023

☀️ Try build successful - checks-actions
Build commit: fe246d4bdf58a842787875da6815f4d4e44c4e92 (fe246d4bdf58a842787875da6815f4d4e44c4e92)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fe246d4bdf58a842787875da6815f4d4e44c4e92): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.3% [1.2%, 1.4%] 2
Regressions ❌
(secondary)		 2.9% [0.4%, 4.3%] 9
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.3% [1.2%, 1.4%] 2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.6% [3.6%, 3.7%] 3
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.6% [3.6%, 3.7%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 8, 2023
@GuillaumeGomez
Copy link
Member

I really like this approach. Does it makes sense to you too @jsha?

@notriddle
Copy link
Contributor Author

The apparent perf regressions aren't on doc, so they're probably noise. Here's the html bytes results: https://perf.rust-lang.org/compare.html?start=b082e80e20475b1ec5b0bd0dd1dac3e6759c8022&end=fe246d4bdf58a842787875da6815f4d4e44c4e92&stat=size%3Adoc_bytes

@GuillaumeGomez
Copy link
Member

It's a shame that we don't size the actual size difference. But the numbers are very encouraging.

@notriddle
Copy link
Contributor Author

@GuillaumeGomez Doesn't the "Display raw data" checkbox do that?

@GuillaumeGomez
Copy link
Member

😱 TIL

@notriddle
Copy link
Contributor Author

r? @GuillaumeGomez

@rustbot rustbot assigned GuillaumeGomez and unassigned jsha Feb 17, 2023
@GuillaumeGomez
Copy link
Member

Sorry, forgot to approve.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 18, 2023

📌 Commit 894c986 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2023
@Dylan-DPC Dylan-DPC mentioned this pull request Feb 19, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2023
@bors
Auto merge of rust-lang#108228 - Dylan-DPC:rollup-i9t13qu, r=Dylan-DPC
eebdfb5 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#104659 (reflow the stack size story)
 - rust-lang#106933 (Update documentation of select_nth_unstable and select_nth_unstable_by to state O(n^2) complexity)
 - rust-lang#107783 (rustdoc: simplify DOM for `.item-table`)
 - rust-lang#107951 (resolve: Fix doc links referring to other crates when documenting proc macro crates directly)
 - rust-lang#108130 ("Basic usage" is redundant for there is just one example)
 - rust-lang#108146 (rustdoc: hide `reference` methods in search index)
 - rust-lang#108189 (Fix some more `non_lifetime_binders` stuff with higher-ranked trait bounds)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4165de4 into rust-lang:master Feb 19, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 19, 2023
@notriddle notriddle deleted the notriddle/item-table-ul branch February 19, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
6 participants
@notriddle @rustbot @rust-timer @bors @GuillaumeGomez @jsha