Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid copy-pasting the ilog panic string in a bunch of places #107961

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Avoid copy-pasting the ilog panic string in a bunch of places #107961

merged 1 commit into from
Feb 13, 2023

Conversation

scottmcm
Copy link
Member

I also ended up changing the implementations to if let because it doesn't work to

self.checked_ilog2().unwrap_or_else(panic_for_nonpositive_argument)

due to the !. But as a bonus that meant I could remove the rustc_allow_const_fn_unstable too.

@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 12, 2023
@rustbot

This comment was marked as resolved.

Sign in to view
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 12, 2023

📌 Commit 404e9c5 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2023
@Dylan-DPC Dylan-DPC mentioned this pull request Feb 13, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 13, 2023
@bors
Auto merge of rust-lang#107980 - Dylan-DPC:rollup-u4b19bl, r=Dylan-DPC
2008188 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#107654 (reword descriptions of the deprecated int modules)
 - rust-lang#107915 (Add `array::map` benchmarks)
 - rust-lang#107961 (Avoid copy-pasting the `ilog` panic string in a bunch of places)
 - rust-lang#107962 (Add a doc note about why `Chain` is not `ExactSizeIterator`)
 - rust-lang#107966 (Update browser-ui-test version to 0.14.3)
 - rust-lang#107970 (Hermit: Remove floor symbol)
 - rust-lang#107973 (Fix unintentional UB in SIMD tests)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2ec6aeb into rust-lang:master Feb 13, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 13, 2023
@scottmcm scottmcm deleted the unify-ilog-panics branch February 14, 2023 03:03
@tgross35 tgross35 mentioned this pull request Aug 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
4 participants
@scottmcm @rustbot @Mark-Simulacrum @bors