don't into self #108104
Merged
don't into self #108104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nagisa (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
matthiaskrgr
force-pushed
the
into
branch
3 times, most recently
from
92c5682
to
c75ab7a
Compare
mejrs
reviewed
Feb 16, 2023
src/librustdoc/clean/utils.rs
Outdated
| @@ -129,7 +129,7 @@ fn external_generic_args<'tcx>( | |||
| }); | |||
| GenericArgs::Parenthesized { inputs, output } | |||
| } else { | |||
| GenericArgs::AngleBracketed { args: args.into(), bindings: bindings.into() } | |||
| GenericArgs::AngleBracketed { args: args.into(), bindings: bindings } | |||
There was a problem hiding this comment.
you can do
Suggested change
| GenericArgs::AngleBracketed { args: args.into(), bindings: bindings } | |
| GenericArgs::AngleBracketed { args: args.into(), bindings } |
|
r=me with nit |
don't into()-convert types to themselves
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 17, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#104068 (rustdoc: Add PartialOrd trait to doc comment explanation) - rust-lang#107489 (Implement partial support for non-lifetime binders) - rust-lang#107905 (Pass arguments to `x` subcommands with `--`) - rust-lang#108009 (Move some tests) - rust-lang#108086 (wasm: Register the `relaxed-simd` target feature) - rust-lang#108104 (don't into self) - rust-lang#108133 (Small cleanups around `EarlyBinder`) - rust-lang#108136 (Do not ICE on unmet trait alias impl bounds) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't into()-convert types to themselves