Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle links starting with whitespace #108129

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Feb 16, 2023

Fixes #107995.

I just got this issue, wrote a fix and then saw the issue. So here's the PR. ^^'

r? @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 16, 2023
@petrochenkov
Copy link
Contributor

I have actually just checked out a new branch for fixing this before going through the mail and seeing this PR.

@petrochenkov
Copy link
Contributor

Could you add all the test cases from #107995?

/// [ Path`]
/// [ `Path`]

and

#[doc = "line ["]
#[doc = "Path"]
#[doc = "] line"]

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2023
@GuillaumeGomez GuillaumeGomez force-pushed the correctly-handle-links-starting-with-whitespace branch from 3e7a980 to 8d1c662 Compare February 16, 2023 21:57
@GuillaumeGomez
Copy link
Member Author

I added the suggested test cases.

@bors

This comment was marked as resolved.

@GuillaumeGomez GuillaumeGomez force-pushed the correctly-handle-links-starting-with-whitespace branch from 8d1c662 to 05f2fad Compare February 16, 2023 23:22
@GuillaumeGomez GuillaumeGomez force-pushed the correctly-handle-links-starting-with-whitespace branch from 05f2fad to 8d801fd Compare February 18, 2023 22:25
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Feb 19, 2023

📌 Commit 8d801fd has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 19, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2023
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#107766 (Fix json reexports of different items with same name)
 - rust-lang#108129 (Correctly handle links starting with whitespace)
 - rust-lang#108188 (Change src/etc/vscode_settings.json to always treat ./library as the sysroot source)
 - rust-lang#108203 (Fix RPITITs in default trait methods (by assuming projection predicates in param-env))
 - rust-lang#108212 (Download rustfmt regardless of rustc being set in config.toml)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bd63edc into rust-lang:master Feb 19, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 19, 2023
@GuillaumeGomez GuillaumeGomez deleted the correctly-handle-links-starting-with-whitespace branch February 19, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustdoc Internal Compiler Error for Diesel
4 participants