-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly handle links starting with whitespace #108129
Merged
bors
merged 2 commits into
rust-lang:master
from
GuillaumeGomez:correctly-handle-links-starting-with-whitespace
Feb 19, 2023
Merged
Correctly handle links starting with whitespace #108129
bors
merged 2 commits into
rust-lang:master
from
GuillaumeGomez:correctly-handle-links-starting-with-whitespace
Feb 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Feb 16, 2023
I have actually just checked out a new branch for fixing this before going through the mail and seeing this PR. |
Could you add all the test cases from #107995? /// [ Path`]
/// [ `Path`] and #[doc = "line ["]
#[doc = "Path"]
#[doc = "] line"] |
petrochenkov
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 16, 2023
GuillaumeGomez
force-pushed
the
correctly-handle-links-starting-with-whitespace
branch
from
February 16, 2023 21:57
3e7a980
to
8d1c662
Compare
I added the suggested test cases. |
This comment was marked as resolved.
This comment was marked as resolved.
GuillaumeGomez
force-pushed
the
correctly-handle-links-starting-with-whitespace
branch
from
February 16, 2023 23:22
8d1c662
to
05f2fad
Compare
GuillaumeGomez
force-pushed
the
correctly-handle-links-starting-with-whitespace
branch
from
February 18, 2023 22:25
05f2fad
to
8d801fd
Compare
@bors r+ |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Feb 19, 2023
This was referenced Feb 19, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 19, 2023
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#107766 (Fix json reexports of different items with same name) - rust-lang#108129 (Correctly handle links starting with whitespace) - rust-lang#108188 (Change src/etc/vscode_settings.json to always treat ./library as the sysroot source) - rust-lang#108203 (Fix RPITITs in default trait methods (by assuming projection predicates in param-env)) - rust-lang#108212 (Download rustfmt regardless of rustc being set in config.toml) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
GuillaumeGomez
deleted the
correctly-handle-links-starting-with-whitespace
branch
February 19, 2023 18:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107995.
I just got this issue, wrote a fix and then saw the issue. So here's the PR. ^^'
r? @petrochenkov