-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ICE on type alias in recursion #108168
Conversation
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
This could use more information about why the recursion happens, either in the PR or the code itself, since the fix is not exactly self-documenting. But I think I understand it. Do you mind doing that? |
I'm not 100% certain of the issue, but as I understand it, rust/compiler/rustc_metadata/src/rmeta/encoder.rs Lines 1206 to 1208 in f4f5fc3
find_item_ty_spans doesn't check whether it's behind an alias, so panics when it tries to query that.Just after the top-level call to the function there's a comment mentioning type aliases rust/compiler/rustc_middle/src/values.rs Lines 146 to 147 in f4f5fc3
which suggests that maybe this check was just forgotten |
I understand the bug now. Yeah, it makes sense to filter out type aliases here -- @bors r+ |
…compiler-errors Fix ICE on type alias in recursion Fixes rust-lang#108160
…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#108110 (Move some `InferCtxt` methods to `EvalCtxt` in new solver) - rust-lang#108168 (Fix ICE on type alias in recursion) - rust-lang#108230 (Convert a hard-warning about named static lifetimes into lint "unused_lifetimes") - rust-lang#108239 (Fix overlapping spans in removing extra arguments) - rust-lang#108246 (Add an InstCombine for redundant casts) - rust-lang#108264 (no-fail-fast support for tool testsuites) - rust-lang#108310 (rustdoc: Fix duplicated attributes for first reexport) - rust-lang#108318 (Remove unused FileDesc::get_cloexec) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #108160