Use a macro in lang_items to remove duplication. #10832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make maintenance of lang items simpler and also reduces the line count by about 201 lines.
| lets_do_this! { | ||
| There are 41 lang items. | ||
|
|
||
| // ID, Variant name, Name, Method name; |
There was a problem hiding this comment.
This header could be part of the macro definition, not just a comment.
There are 41 lang items. The lang items follow:
ID, Variant name, Name, Method name;
// ...:P
There was a problem hiding this comment.
Sure; we can go for a full-blown literate coding style if we want, too!
(I'll leave that to your imagination.)
|
@alexcrichton not needing to keep track of the numbers at all would be handy; to do that, we'd need a (a) a counter syntax extension (something like the CSS counters module) which can be used inside a repeat, and (b) some way of counting repeats in macros (to get the number 41). Those are certainly out of scope for this particular thing. |
bors
added a commit
that referenced
this pull request
Dec 6, 2013
…nt, r=alexcrichton This should make maintenance of lang items simpler and also reduces the line count by about 201 lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make maintenance of lang items simpler and also reduces the
line count by about 201 lines.