-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap missing provider message correctly #108433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @eholk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Feb 24, 2023
r? Nilstrieb |
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 24, 2023
@bors r=Nilstrieb |
💡 This pull request was already approved, no need to approve it again.
|
Thanks for this! :) |
I'm guessing the left padding wasn't originally intended, but it also doesn't overly hurt. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 24, 2023
…it, r=Nilstrieb Wrap missing provider message correctly Fixes rust-lang#108429 ``` error: internal compiler error: compiler/rustc_middle/src/ty/query.rs:441:1: `tcx.trigger_delay_span_bug(DefId(0:3 ~ test[78c5]::main))` is not supported for local crate; hint: Queries can be either made to the local crate, or the external crate. This error means you tried to use it for one that's not supported. If that's not the case, trigger_delay_span_bug was likely never assigned to a provider function. thread 'rustc' panicked at 'Box<dyn Any>', /home/ec2-user/rust3/compiler/rustc_errors/src/lib.rs:1651:9 stack backtrace: 0: 0x7f51870926d7 - std::backtrace_rs::backtrace::libunwind::trace::hb0876bb39e7adf0d at /home/ec2-user/rust3/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5 1: 0x7f51870926d7 - std::backtrace_rs::backtrace::trace_unsynchronized::h1bcab1313827007b at /home/ec2-user/rust3/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5 2: 0x7f5187077e07 - std::sys_common::backtrace::_print_fmt::h262d2a62279fa102 at /home/ec2-user/rust3/library/std/src/sys_common/backtrace.rs:65:5 ```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 25, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#108354 (Update `fuchsia-test-runner.py` and docs) - rust-lang#108404 (support `x fmt` for sub and outside of rust directories) - rust-lang#108407 (docs: use intra-doc links for `Vec::get(_mut)`) - rust-lang#108410 (rustdoc: avoid including `<li>` tags in item table short desc) - rust-lang#108412 (Fix GUI test navigation bug) - rust-lang#108433 (Wrap missing provider message correctly) - rust-lang#108434 (Migrate `rustc_hir_analysis` to session diagnostic [Part One]) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
a-hosani
approved these changes
Feb 25, 2023
BoxyUwU
approved these changes
Feb 25, 2023
Noratrieb
approved these changes
Feb 25, 2023
oli-obk
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108429