-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate rustc_hir_analysis
to session diagnostic [Part Two]
#108460
Merged
bors
merged 1 commit into
rust-lang:master
from
obeis:hir-analysis-migrate-diagnostics-2
Mar 8, 2023
Merged
migrate rustc_hir_analysis
to session diagnostic [Part Two]
#108460
bors
merged 1 commit into
rust-lang:master
from
obeis:hir-analysis-migrate-diagnostics-2
Mar 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @spastorino (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Feb 25, 2023
compiler-errors
requested changes
Feb 25, 2023
compiler/rustc_hir_analysis/src/structured_errors/missing_cast_for_variadic_arg.rs
Outdated
Show resolved
Hide resolved
compiler/rustc_hir_analysis/src/structured_errors/missing_cast_for_variadic_arg.rs
Outdated
Show resolved
Hide resolved
compiler/rustc_hir_analysis/src/structured_errors/sized_unsized_cast.rs
Outdated
Show resolved
Hide resolved
☔ The latest upstream changes (presumably #108450) made this pull request unmergeable. Please resolve the merge conflicts. |
obeis
force-pushed
the
hir-analysis-migrate-diagnostics-2
branch
2 times, most recently
from
February 26, 2023 18:33
871f701
to
3abf98f
Compare
☔ The latest upstream changes (presumably #108707) made this pull request unmergeable. Please resolve the merge conflicts. |
part two files list: rustc_hir_analysis/variance/* rustc_hir_analysis/missing_cast_for_variadic_arg.rs rustc_hir_analysis/sized_unsized_cast.rs
obeis
force-pushed
the
hir-analysis-migrate-diagnostics-2
branch
from
March 4, 2023 21:02
3abf98f
to
44eb974
Compare
Leaving this up to @compiler-errors or @davidtwco maybe? |
r? @compiler-errors @bors r+ |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 7, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 7, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#108460 (migrate `rustc_hir_analysis` to session diagnostic [Part Two]) - rust-lang#108581 (Add a new config flag, dist.include-mingw-linker.) - rust-lang#108583 (Account for binders correctly when adding default RPITIT method assumption) - rust-lang#108783 (Sync rustc_codegen_gcc 2023/03/04) - rust-lang#108793 (Append to existing `PYTHONPATH` in compiletest instead of overwriting) - rust-lang#108822 (Remove references to PassManagerBuilder) - rust-lang#108866 (Force to use the stage 2 compiler when config.download_rustc is set) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate
rustc_hir_analysis
to session diagnostic (part two)files list:
Updates #100717