-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forbid the use of #[target_feature]
on main
#108651
Forbid the use of #[target_feature]
on main
#108651
Conversation
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r? Nilstrieb
@bors delegate
r=me when CI is green
Uh, I don't think |
waffle rustc log analyzer There are two failures:
|
Hm, Ig it is fine, actually? Maybe? If the codegen only happens inside the crate, then |
This isn't unsound, the safeaty check probably goes through target feature queries instead of the attr. |
Yes, see rust/compiler/rustc_mir_transform/src/check_unsafety.rs Lines 363 to 365 in 18caf88
|
Also we need to forbid |
23db00f
to
aa67dbe
Compare
Now it looks good and green 😊 |
…ure-on-main, r=Nilstrieb Forbid the use of `#[target_feature]` on `main` Fixes rust-lang#108645.
@bors r- this will fail after the revert, needs to add the unstable feature to the test |
(I'll need to add the feature gates back if #108654 lands first) |
1072bc8
to
faebedf
Compare
Since |
a52a586
to
7841b8b
Compare
Some changes occurred in src/tools/cargo cc @ehuss |
7841b8b
to
28dca77
Compare
(Committed a submodule change by accident, sorry for the noise) |
@bors r+ |
📌 Commit 28dca77acf1d7280b51372abf3dd50c14616b628 has been approved by It is now in the queue for this repository. |
☔ The latest upstream changes (presumably #108682) made this pull request unmergeable. Please resolve the merge conflicts. |
28dca77
to
29b1789
Compare
@bors r+ |
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#108651 (Forbid the use of `#[target_feature]` on `main`) - rust-lang#109009 (rustdoc: use restricted Damerau-Levenshtein distance for search) - rust-lang#109026 (Introduce `Rc::into_inner`, as a parallel to `Arc::into_inner`) - rust-lang#109029 (Gate usages of `dyn*` and const closures in macros) - rust-lang#109031 (Rename `config.toml.example` to `config.example.toml`) - rust-lang#109032 (Use `TyCtxt::trait_solver_next` in some places) - rust-lang#109047 (typo) - rust-lang#109052 (Add eslint check for rustdoc-gui tester) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #108645.