Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit the suspicious_auto_trait_impls for negative impls as well #108807

Merged
merged 4 commits into from
Mar 7, 2023
Merged

Emit the suspicious_auto_trait_impls for negative impls as well #108807

merged 4 commits into from
Mar 7, 2023

Conversation

mu001999
Copy link
Contributor

@mu001999 mu001999 commented Mar 6, 2023

Fixes #108804

@rustbot
Copy link
Collaborator

rustbot commented Mar 6, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Nilstrieb (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 6, 2023
@mu001999
Copy link
Contributor Author

mu001999 commented Mar 6, 2023

r? @lcnr

@rustbot rustbot assigned lcnr and unassigned Noratrieb Mar 6, 2023
@lcnr
Copy link
Contributor

lcnr commented Mar 6, 2023 •
edited
Loading

you have to bless the remaining ui tests as well ./x.py test tests/ui --bless

also, can you move the negative impls into a separate test file, maybe called tests/ui/auto-traits/suspicious-negative-impls-lint.rs

r=me after that

@lcnr
Copy link
Contributor

lcnr commented Mar 6, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 6, 2023

📌 Commit 717f93c has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 6, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 6, 2023
@matthiaskrgr
Rollup merge of rust-lang#108807 - MU001999:lint/suspicious_auto_trai…
0f95961 
…t_impls, r=lcnr

Emit the suspicious_auto_trait_impls for negative impls as well

Fixes rust-lang#108804
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 6, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 6, 2023
@bors
Auto merge of rust-lang#108821 - matthiaskrgr:rollup-cmkbgpr, r=matth…
81be7b8 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#107801 (const_eval: `implies_by` in `rustc_const_unstable`)
 - rust-lang#108750 (Fix `ObligationCtxt::sub`)
 - rust-lang#108780 (Add regression tests for issue 70919)
 - rust-lang#108786 (Check for free regions in MIR validation)
 - rust-lang#108790 (Do not ICE when interpreting a cast between non-monomorphic types)
 - rust-lang#108803 (Do not ICE when failing to normalize in ConstProp.)
 - rust-lang#108807 (Emit the suspicious_auto_trait_impls for negative impls as well)
 - rust-lang#108812 (Add regression test for rust-lang#98444)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3279f7e into rust-lang:master Mar 7, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 7, 2023
@mu001999 mu001999 deleted the lint/suspicious_auto_trait_impls branch March 7, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

emit the suspicious_auto_trait_impls for negative impls as well
5 participants
@mu001999 @rustbot @lcnr @bors @Noratrieb