Enforce non-lifetime-binders in supertrait preds are not object safe #108842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
compiler-errors
commented
Mar 7, 2023
| fn super_predicates_have_non_lifetime_binders( | ||
| tcx: TyCtxt<'_>, | ||
| trait_def_id: DefId, | ||
| ) -> SmallVec<[Span; 1]> { |
There was a problem hiding this comment.
Perf: I guess we could bail early here if !tcx.features().non_lifetime_binders...
compiler-errors
added
the
F-non_lifetime_binders
|
r? compiler |
b-naber
approved these changes
Mar 20, 2023
| @@ -921,6 +924,9 @@ impl ObjectSafetyViolation { | |||
| .into() | |||
| } | |||
| } | |||
| ObjectSafetyViolation::SupertraitNonLifetimeBinder(_) => { | |||
| format!("predicate cannot reference non-lifetime `for<...>` bound variables").into() | |||
There was a problem hiding this comment.
Should me maybe use a more user-friendly error message here? Can we expect users to know what predicates are?
There was a problem hiding this comment.
i would hope if they're using non-lifetime binders, but I guess i can de-types-ify the message by saying "where clause" 😸
| fn super_predicates_have_non_lifetime_binders( | ||
| tcx: TyCtxt<'_>, | ||
| trait_def_id: DefId, | ||
| ) -> SmallVec<[Span; 1]> { |
compiler-errors
force-pushed
the
non_lifetime_binders-object-safe
branch
from
7d28725
to
720cc40
Compare
|
Thanks. @bors r+ rollup |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 21, 2023
…rs-object-safe, r=b-naber Enforce non-lifetime-binders in supertrait preds are not object safe We can't construct vtables for these supertraits.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 21, 2023
…rs-object-safe, r=b-naber Enforce non-lifetime-binders in supertrait preds are not object safe We can't construct vtables for these supertraits.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 21, 2023
…rs-object-safe, r=b-naber Enforce non-lifetime-binders in supertrait preds are not object safe We can't construct vtables for these supertraits.
Noratrieb
added a commit
to Noratrieb/rust
that referenced
this pull request
Mar 21, 2023
…rs-object-safe, r=b-naber Enforce non-lifetime-binders in supertrait preds are not object safe We can't construct vtables for these supertraits.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 21, 2023
Rollup of 10 pull requests Successful merges: - rust-lang#106434 (Document `Iterator::sum/product` for Option/Result) - rust-lang#108326 (Implement read_buf for a few more types) - rust-lang#108842 (Enforce non-lifetime-binders in supertrait preds are not object safe) - rust-lang#108896 (new solver: make all goal evaluation able to be automatically rerun ) - rust-lang#109124 (Add `dist.compression-profile` option to control compression speed) - rust-lang#109240 (Walk un-shifted nested `impl Trait` in trait when setting up default trait method assumptions) - rust-lang#109385 (fix typo) - rust-lang#109386 (add myself to mailmap) - rust-lang#109390 (Custom MIR: Support aggregate expressions) - rust-lang#109408 (not *all* retags might be explicit in Runtime MIR) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't construct vtables for these supertraits.