Manual: proto! is gone
#10901
Closed
Manual: proto! is gone
#10901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following files need to be adjusted, too (i can't do it now): - doc/po/ja/rust.md.po - doc/po/rust.md.pot
|
The japanese translation has been left unmaintained since it's been PR'ed iirc. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2023
…h,Centri3 [`useless_vec`]: lint `vec!` invocations when a slice or an array would do First off, sorry for that large diff in tests. *A lot* of tests seem to trigger the lint with this new change, so I decided to `#![allow()]` the lint in the affected tests to make reviewing this easier, and also split the commits up so that the first commit is the actual logic of the lint and the second commit contains all the test changes. The stuff that changed in the tests is mostly just line numbers now. So, as large as the diff looks, it's not actually that bad. 😅 I manually went through all of these to find out about edge cases and decided to put them in `tests/ui/vec.rs`. For more context, I wrote about the idea of this PR here: rust-lang/rust-clippy#2262 (comment) (that explains the logic) Basically, it now also considers the case where a `Vec` is put in a local variable and the user only ever does things with it that one could also do with a slice or an array. This should catch a lot more cases, and (at least from looking at the tests) it does. changelog: [`useless_vec`]: lint `vec!` invocations when a slice or an array would do (also considering local variables now)
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2023
[`useless_vec`]: lint on `vec![_]` invocations that adjust to a slice Fixes rust-lang#2262 (well, actually my PR over at rust-lang#10901 did do most of the stuff, but this PR implements the one last other case mentioned in the comments that my PR didn't fix) Before this change, it would lint `(&vec![1]).iter().sum::<i32>()`, but not `vec![1].iter().sum::<i32>()`. This PR handles this case. This also refactors a few things that I wanted to do in my other PR but forgot about. changelog: [`useless_vec`]: lint on `vec![_]` invocations that adjust to a slice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following files need to be adjusted, too (i can't do it now):