Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use the new DepNode hashmap for anonymous nodes. #109050

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Only use the new DepNode hashmap for anonymous nodes. #109050

wants to merge 9 commits into from

Commits on Aug 18, 2024

  1. Verify dep-graph consistency when loading it. 

    Always recover from duplicate DepNode.
    @cjgillot
    cjgillot committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    563203f View commit details
    Browse the repository at this point in the history

  2. Only use the new node hashmap for anonymous nodes.

    @cjgillot
    cjgillot committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    052fdf8 View commit details
    Browse the repository at this point in the history

  3. Bless test for constant queries. 

    As the hash function for the input is not complete, those queries can
trigger a re-use of a DepNode.  As we now tolerate having duplicated
DepNode, we effectively remove this ICE.
    @cjgillot
    cjgillot committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    a3d06f8 View commit details
    Browse the repository at this point in the history

  4. Add a flag to check depnodes for collisions.

    @cjgillot
    cjgillot committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    1bd74a3 View commit details
    Browse the repository at this point in the history

  5. Reintroduce assertion.

    @cjgillot
    cjgillot committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    f82b2e2 View commit details
    Browse the repository at this point in the history

  6. Reuse -Zincremental_verify_ich.

    @cjgillot
    cjgillot committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    f37fe42 View commit details
    Browse the repository at this point in the history

  7. Add extra assertion.

    @cjgillot
    cjgillot committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    76f15da View commit details
    Browse the repository at this point in the history

  8. Do not fetch the DepNode to mark nodes green.

    @cjgillot
    cjgillot committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    4272c6b View commit details
    Browse the repository at this point in the history

  9. Silence lint.

    @cjgillot
    cjgillot committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    99ecfbc View commit details
    Browse the repository at this point in the history