Check for llvm-tools before install #109256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @albertlarsan68 (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
|
Thanks for the PR! |
bors
added
S-waiting-on-bors
|
Can't give much of a review but I can confirm this PR fixes #108948 and install skips llvm tools installation now: |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 17, 2023
…san68 Check for llvm-tools before install Fixes rust-lang#108948 `@jpalus` Please review
This was referenced Mar 17, 2023
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 17, 2023
…san68 Check for llvm-tools before install Fixes rust-lang#108948 ``@jpalus`` Please review
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 17, 2023
…san68 Check for llvm-tools before install Fixes rust-lang#108948 ```@jpalus``` Please review
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#109102 (Erase escaping late-bound regions when probing for ambiguous associated types) - rust-lang#109200 (Fix index out of bounds in `suggest_trait_fn_ty_for_impl_fn_infer`) - rust-lang#109211 (E0206 - update description ) - rust-lang#109222 (Do not ICE for unexpected lifetime with ConstGeneric rib) - rust-lang#109235 (fallback to lstat when stat fails on Windows) - rust-lang#109248 (Pass the right HIR back from `get_fn_decl`) - rust-lang#109251 (Suggest surrounding the macro with `{}` to interpret as a statement) - rust-lang#109256 (Check for llvm-tools before install) - rust-lang#109257 (resolve: Improve debug impls for `NameBinding`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This was referenced Mar 18, 2023
onur-ozkan
reviewed
Mar 18, 2023
| .ensure(dist::LlvmTools { target: self.target }) | ||
| .expect("missing llvm-tools"); | ||
| install_sh(builder, "llvm-tools", self.compiler.stage, Some(self.target), &tarball); | ||
| if let Some(tarball) = builder.ensure(dist::LlvmTools { target: self.target }) { |
There was a problem hiding this comment.
I don't think this approach was right.
There was a problem hiding this comment.
@ozkanonur Thank you for fixing.
wip-sync
pushed a commit
to NetBSD/pkgsrc-wip
that referenced
this pull request
Mar 21, 2023
pld-gitsync
pushed a commit
to pld-linux/rust
that referenced
this pull request
Apr 20, 2023
- use upstream fix for llvm tools install issue from: rust-lang/rust#109256 - rust analysis dropped upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108948
@jpalus Please review