-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce that PointerLike
requires a pointer-like ABI
#109413
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
☔ The latest upstream changes (presumably #108080) made this pull request unmergeable. Please resolve the merge conflicts. |
dfe4690
to
2d2385f
Compare
compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs
Outdated
Show resolved
Hide resolved
2d2385f
to
920c51c
Compare
@bors r=cjgillot |
☀️ Test successful - checks-actions |
Finished benchmarking commit (0030465): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
At least temporarily, let's ban coercing things that are pointer-sized and pointer-aligned but not
Abi::Scalar(..)
intodyn*
. See: #104694 (comment)This can be lifted in the future if we decie that we want to be able to coerce something
repr(C)
into adyn*
, but we'll have to figure out what to do with Miri and codegen...r? compiler