Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #109496

Merged
merged 27 commits into from
Mar 22, 2023
Merged

Rollup of 11 pull requests #109496

merged 27 commits into from
Mar 22, 2023

Commits on Oct 6, 2022

  1. Rename LinesAnyMap to LinesMap

    lines_any method was replaced with lines method, so it
    makes sense to rename this structure to match new name.
    
    Co-authored-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
    KamilaBorowska and ijackson committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    0d8a0c5 View commit details
    Browse the repository at this point in the history
  2. Fix handling of trailing bare CR in str::lines

    Previously "bare\r" was split into ["bare"] even though the
    documentation said that only LF and CRLF count as newlines.
    
    This fix is a behavioural change, even though it brings the behaviour
    into line with the documentation, and into line with that of
    `std::io::BufRead::lines()`.
    
    This is an alternative to rust-lang#91051, which proposes to document rather
    than fix the behaviour.
    
    Fixes rust-lang#94435.
    
    Co-authored-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
    KamilaBorowska and ijackson committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    cef81dc View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Render source page layout with Askama

    Co-authored-by: Michael Howell <michael@notriddle.com>
    clubby789 and notriddle committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    102c8fa View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. Remove VecMap

    compiler-errors committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    6639538 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2023

  1. Configuration menu
    Copy the full SHA
    27e9ee9 View commit details
    Browse the repository at this point in the history
  2. refactor fn bootstrap::builder::Builder::compiler_for

    - check compiler stage before forcing for stage2.
    - check if download_rustc is not set before forcing for stage1.
    
    Signed-off-by: ozkanonur <work@onurozkan.dev>
    onur-ozkan committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    2ec7f6c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    572c56c View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Add a layout argument to enforce_validity.

    This is in preparation of checking the validity only of certain types.
    oli-obk committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    83dec62 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f066d67 View commit details
    Browse the repository at this point in the history
  3. rustdoc: Cleanup parent module tracking for doc links

    Keep ids of the documented items themselves, not their parent modules.
    Parent modules can be retreived from those ids when necessary.
    petrochenkov committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    d3a5541 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0f45d85 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4212c1b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    364a5d4 View commit details
    Browse the repository at this point in the history
  7. Always encode RPITITs

    spastorino authored and compiler-errors committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    c1f3529 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c3e6f68 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Change text -> rust,ignore highlighting in sanitizer.md

    Marked ignore due to difficulty getting doctests to pass cross-platform
    tgross35 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    df034b0 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#100311 - xfix:lines-fix-handling-of-bare-cr…

    …, r=ChrisDenton
    
    Fix handling of trailing bare CR in str::lines
    
    Continuing from rust-lang#91191.
    
    Fixes rust-lang#94435.
    Dylan-DPC authored Mar 22, 2023
    Configuration menu
    Copy the full SHA
    d694f47 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#108997 - tgross35:patch-1, r=JohnTitor

    Change text -> rust highlighting in sanitizer.md
    
    Not sure why this has syntax highlighting turned off, but it doesn't need to be
    
    Relevant page: https://doc.rust-lang.org/beta/unstable-book/compiler-flags/sanitizer.html
    Dylan-DPC authored Mar 22, 2023
    Configuration menu
    Copy the full SHA
    59d9cbf View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#109179 - llogiq:intrinsically-option-as-sli…

    …ce, r=eholk
    
    move Option::as_slice to intrinsic
    
    ````@scottmcm```` suggested on rust-lang#109095 I use a direct approach of unpacking the operation in MIR lowering, so here's the implementation.
    
    cc ````@nikic```` as this should hopefully unblock rust-lang#107224 (though perhaps other changes to the prior implementation, which I left for bootstrapping, are needed).
    Dylan-DPC authored Mar 22, 2023
    Configuration menu
    Copy the full SHA
    14d0646 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#109187 - clubby789:askama-source, r=Guillau…

    …meGomez
    
    Render source page layout with Askama
    
    ~~I was looking at making `code_html` render into the buffer instead of in advance, but it turned out to need a pretty big refactor, so starting with rearranging the high-level layout.~~
    Found another approach which required much less changes
    
    cc rust-lang#108868
    Dylan-DPC authored Mar 22, 2023
    Configuration menu
    Copy the full SHA
    d8543ab View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#109280 - compiler-errors:no-vec-map, r=Mark…

    …-Simulacrum
    
    Remove `VecMap`
    
    Not sure what the use of this data structure is over just using `FxIndexMap` or a `Vec`.
    
    r? ```@ghost```
    Dylan-DPC authored Mar 22, 2023
    Configuration menu
    Copy the full SHA
    70918ec View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#109295 - ozkanonur:issue-109286, r=ozkanonur

    refactor `fn bootstrap::builder::Builder::compiler_for` logic
    
    - check compiler stage before forcing for stage2.
    - check if download_rustc is not set before forcing for stage1.
    
    resolves rust-lang#109286
    Dylan-DPC authored Mar 22, 2023
    Configuration menu
    Copy the full SHA
    7a57d88 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#109312 - petrochenkov:docice5, r=GuillaumeG…

    …omez
    
    rustdoc: Cleanup parent module tracking for doc links
    
    Keep ids of the documented items themselves, not their parent modules. Parent modules can be retreived from those ids when necessary.
    
    Fixes rust-lang#108501.
    That issue could be fixed in a more local way, but this refactoring is something that I wanted to do since rust-lang#93805 anyway.
    Dylan-DPC authored Mar 22, 2023
    Configuration menu
    Copy the full SHA
    af3bd22 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#109317 - ehuss:discriminant-link-fix, r=Nil…

    …strieb
    
    Update links for custom discriminants.
    
    The discriminant documentation was updated in rust-lang/reference#1055 which changed the layout a bit. This updates the links to the updated locations.
    Dylan-DPC authored Mar 22, 2023
    Configuration menu
    Copy the full SHA
    8ce52b7 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#109405 - compiler-errors:rpitit-as-opaques,…

    … r=spastorino
    
    RPITITs are `DefKind::Opaque` with new lowering strategy
    
    r? `@spastorino`
    
    Kinda cherry-picked rust-lang#109400
    Dylan-DPC authored Mar 22, 2023
    Configuration menu
    Copy the full SHA
    b9151b2 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#109414 - spastorino:new-rpitit-16, r=compil…

    …er-errors
    
    Do not consider synthesized RPITITs on missing items checks
    
    Without this patch for `tests/ui/impl-trait/in-trait/dont-project-to-rpitit-with-no-value.rs` we get ...
    
    ```
    warning: the feature `return_position_impl_trait_in_trait` is incomplete and may not be safe to use and/or cause compiler crashes
     --> tests/ui/impl-trait/in-trait/dont-project-to-rpitit-with-no-value.rs:4:12
      |
    4 | #![feature(return_position_impl_trait_in_trait)]
      |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      |
      = note: see issue rust-lang#91611 <rust-lang#91611> for more information
      = note: `#[warn(incomplete_features)]` on by default
    
    error[E0046]: not all trait items implemented, missing: `foo`, ``
      --> tests/ui/impl-trait/in-trait/dont-project-to-rpitit-with-no-value.rs:12:1
       |
    8  |     fn foo(&self) -> impl Sized;
       |     ----------------------------
       |     |                |
       |     |                `` from trait
       |     `foo` from trait
    ...
    12 | impl MyTrait for i32 {
       | ^^^^^^^^^^^^^^^^^^^^ missing `foo`, `` in implementation
    
    error: aborting due to previous error; 1 warning emitted
    
    For more information about this error, try `rustc --explain E0046`.
    ```
    
    instead of ...
    
    ```
    warning: the feature `return_position_impl_trait_in_trait` is incomplete and may not be safe to use and/or cause compiler crashes
      --> $DIR/dont-project-to-rpitit-with-no-value.rs:4:12
       |
    LL | #![feature(return_position_impl_trait_in_trait)]
       |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       |
       = note: see issue rust-lang#91611 <rust-lang#91611> for more information
       = note: `#[warn(incomplete_features)]` on by default
    
    error[E0046]: not all trait items implemented, missing: `foo`
      --> $DIR/dont-project-to-rpitit-with-no-value.rs:12:1
       |
    LL |     fn foo(&self) -> impl Sized;
       |     ---------------------------- `foo` from trait
    ...
    LL | impl MyTrait for i32 {
       | ^^^^^^^^^^^^^^^^^^^^ missing `foo` in implementation
    
    error: aborting due to previous error; 1 warning emitted
    
    For more information about this error, try `rustc --explain E0046`.
    ```
    
    r? `@compiler-errors`
    Dylan-DPC authored Mar 22, 2023
    Configuration menu
    Copy the full SHA
    031640c View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#109435 - oli-obk:🇨🇭🥚_copy_op, r=RalfJung

    Detect uninhabited types early in const eval
    
    r? `@RalfJung`
    
    implements rust-lang#108442 (comment)
    
    this is a breaking change, as some UB during const eval is now detected instead of silently being ignored. Users can see this and other UB that may cause future breakage with `-Zextra-const-ub-checks` or just by running miri on their code, which sets that flag by default.
    Dylan-DPC authored Mar 22, 2023
    Configuration menu
    Copy the full SHA
    eda88a3 View commit details
    Browse the repository at this point in the history