Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Unsupport importing doc(primitive) and doc(keyword) modules #109534

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Mar 23, 2023

These are internal features used for a specific purpose, and modules without imports are enough for that purpose.

@rustbot
Copy link
Collaborator

rustbot commented Mar 23, 2023

r? @jsha

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 23, 2023
@rustbot
Copy link
Collaborator

rustbot commented Mar 23, 2023

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2023
These are internal features used for a specific purpose, and modules without imports are enough for that purpose.
@petrochenkov petrochenkov changed the title rustdoc: Unsupport doc(primitive) and doc(keyword) on imports rustdoc: Unsupport importing doc(primitive) and doc(keyword) modules Mar 28, 2023
@petrochenkov
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 28, 2023
@GuillaumeGomez
Copy link
Member

Shouldn't we emit a warning to let users know it's not allowed?

@petrochenkov
Copy link
Contributor Author

My goal was to remove code, if the alternative is to report warning then I'd better keep it supported.
As I understand, we are the only users, since it's an internal feature, so the warning is probably not necessary.

@GuillaumeGomez
Copy link
Member

Sounds fine indeed.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 29, 2023

📌 Commit 52b15b4 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 29, 2023
Rollup of 7 pull requests

Successful merges:

 - rust-lang#108335 (rustdoc + rustdoc-json support for `feature(non_lifetime_binders)`)
 - rust-lang#109534 (rustdoc: Unsupport importing `doc(primitive)` and `doc(keyword)` modules)
 - rust-lang#109659 (llvm-wrapper: adapt for LLVM API change)
 - rust-lang#109664 (Use span of placeholders in format_args!() expansion.)
 - rust-lang#109683 (Check for overflow in `assemble_candidates_after_normalizing_self_ty`)
 - rust-lang#109713 (Fix mismatched punctuation in Debug impl of AttrId)
 - rust-lang#109718 (Rename `IndexVec::last` → `last_index`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1db9eae into rust-lang:master Mar 29, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants