Improve "Auto-hide trait implementation documentation" GUI test #109595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 26, 2023
…to-hide-trait, r=notriddle Improve "Auto-hide trait implementation documentation" GUI test Part of rust-lang#66181. I'll start working on the `include` command for `browser-ui-test` so we can greatly reduce the duplicated code between setting tests. r? `@notriddle`
This was referenced Mar 26, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 26, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#109007 (rustdoc: skip `// some variants omitted` if enum is `#[non_exhaustive]`) - rust-lang#109593 (Rustdoc Book refer to rustdoc::missing_doc_code_examples. Fixes rust-lang#109592.) - rust-lang#109595 (Improve "Auto-hide trait implementation documentation" GUI test) - rust-lang#109619 (Still-further-specializable projections are ambiguous in new solver) - rust-lang#109620 (Correct typo (`back_box` -> `black_box`)) - rust-lang#109621 (Refactor: `VariantIdx::from_u32(0)` -> `FIRST_VARIANT`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #66181.
I'll start working on the
includecommand forbrowser-ui-testso we can greatly reduce the duplicated code between setting tests.r? @notriddle