Fix typo in hint::black_box docs

[lilyyy411]

situ, -> situations

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[rustbot]

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

[Dylan-DPC]

Thanks for the contribution.
However, this looks like it isn't a typo:
»In situ« is a phrase which means »(situated)in the original place«

[danielhenrymantilla]

I do agree that in situ fits quite oddly here. I'd rather myself go with something along the lines of:

would actually be used, where ...

This seems to be, a priori, the intent the original author had (given the comma they wrote), and using in situ/"in the [very] place" is convoluted at best. By using "actually", it will be English rather than Latin, and in this case, simple English, which is a fortiori more accessible.

Ergo, removing that usage of in situ is an improvement, ceteris paribus 🙃: the author going and submitting a PR, motu propio, to discuss it, was thus the right move (although I agree with @Dylan-DPC that "situations where", although not wrong per se, is not what the original author intended).

[lilyyy411]

I thought that this is what the original author intended but apparently I can't read

[tgross35]

I'm the one who originally wrote this and meant "in situ" as "in its natural place"/"in position", i.e., how you would come across this function when it's used in real code. But I see that apparently came off a bit abstract, so might as well KISS 🙂.

This definitely isn't a two commit kind of update though, so please squash and correct the commit message @4gboframram

[Dylan-DPC]

There hasn't been much interest in this and I think the change doesn't clarify the wording more than the original. Closing this as it's been inactive for a while