Rollup of 7 pull requests #110119
Closed
Rollup of 7 pull requests #110119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part 3: Finishing `collect.rs` file
Fix formatting that rustfmt can't handle currently. Co-authored-by: Michael Goulet <michael@errs.io>
…rs-method-probe, r=jackh726 Instantiate instead of erasing binder when probing param methods Fixes rust-lang#108836 There is a really old comment saying that a `WhereClauseCandidate` probe candidate "should not contain any inference variables", but I'm not really confident that that comment applies anymore. In contrast, other candidates that we assemble during method probe contain inference variables in their substitutions (e.g. `InherentImplCandidate`)... Since this change is made only to support a nightly feature, I'm happy to gate the new behavior behind this feature flag or discuss it further. r? types
Updating Wake example to use new 'pin!' macro Updating the example for the Wake trait to use `pin!` macro instead of `Box::pin`. rust-lang#109965
…tics-3, r=compiler-errors Migrate `rustc_hir_analysis` to session diagnostic [Part 3] Part 3: Finishing `collect.rs` file r? `@compiler-errors`
…r=Mark-Simulacrum bump `thiserror` to use syn 2.0 cc rust-lang#109302
…, r=compiler-errors Migrate remainder of rustc_ty_utils to `SessionDiagnostic` This moves the remaining errors in `rust_ty_utils` to `SessionsDiagnostic`. r? `@davidtwco`
…gelog, r=ozkanonur Add renaming of ignore-git to changelog `bootstrap`'s `ignore-git` option has been renamed to `omit-git-hash` in rust-lang#110059. This PR adds this change to the `CHANGELOG.md`. See also rust-lang#110020 (comment).
compiletest: Give a better error message if `node` isn't installed
rustbot
added
A-testsuite
|
@bors r+ rollup=never p=7 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 9f3a751 with merge d429f2d3e2f28603ccf98c35af7dfea656cb061f... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc_hir_analysisto session diagnostic [Part 3] #110028 (Migraterustc_hir_analysisto session diagnostic [Part 3])thiserrorto use syn 2.0 #110081 (bumpthiserrorto use syn 2.0)SessionDiagnostic#110095 (Migrate remainder of rustc_ty_utils toSessionDiagnostic)nodeisn't installed #110114 (compiletest: Give a better error message ifnodeisn't installed)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup