-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #110150
Fix typos #110150
Conversation
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor These commits modify compiler targets. Some changes occurred in src/librustdoc/clean/types.rs cc @camelid Some changes occurred in src/doc/style-guide cc @rust-lang/style Some changes occurred in need_type_info.rs cc @lcnr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR.
This PR touches quite some things and is quite big. Could you split it up into separate PRs for compiler/library/rustdoc? Additionally, I see changes that seem incorrect, I've highlighted one of them. Could you check all the changes yourself again and make sure that you don't see any other problems? I've slimmed through some of the diff and most changes look good though.
AbiData { abi: Abi::PlatformIntrinsic, name: "platform-intrinsic" }, | ||
AbiData { abi: Abi::Unadjusted, name: "unadjusted" }, | ||
AbiData { abi: Abi::RustCold, name: "rust-cold" }, | ||
const AbiData: &[AbiDatum] = &[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct, AbiData is completely fine and correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AbiData
(plural) is a list of AbiDatum
(singular), "datas" doesn't exist. Should I still revert it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
@@ -1428,8 +1428,8 @@ mod prim_ref {} | |||
/// let ptr: fn(usize) -> usize = add_one; | |||
/// assert_eq!(ptr(5), 6); | |||
/// | |||
/// let clos: fn(usize) -> usize = |x| x + 5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's no reason to rename this random variable imo
@@ -1146,7 +1146,7 @@ impl str { | |||
/// | |||
/// assert_eq!(s.find('L'), Some(0)); | |||
/// assert_eq!(s.find('é'), Some(14)); | |||
/// assert_eq!(s.find("pard"), Some(17)); | |||
/// assert_eq!(s.find("part"), Some(17)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what leads you to believe that this should've been named "part"? this is not right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, missed that one
); | ||
i | ||
} | ||
|
||
#[inline] | ||
pub fn data(self) -> &'static AbiData { | ||
&AbiDatas[self.index()] | ||
pub fn data(self) -> &'static AbiDatum { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scope of this PR is way too wide. Renaming structs in the compiler shouldn't be mixed with fixing comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll split it into separate PRs for compiler/library/rustdoc as @Nilstrieb mentioned
The job Click to see the possible cause of the failure (guessed by this bot)
|
Fix typos in compiler I ran [`typos -w compiler`](https://github.com/crate-ci/typos) to fix typos in the `compiler` directory. Refs rust-lang#110150
Fix typos in librustdoc, tools and config files I used [`typos`](https://github.com/crate-ci/typos) to fix all typos, minus the ones present in rust-lang#110153 and in rust-lang#110154. Refs rust-lang#110150
Fix typos in librustdoc, tools and config files I used [`typos`](https://github.com/crate-ci/typos) to fix all typos, minus the ones present in rust-lang#110153 and in rust-lang#110154. Refs rust-lang#110150
Fix typos in compiler I ran [`typos -w compiler`](https://github.com/crate-ci/typos) to fix typos in the `compiler` directory. Refs rust-lang#110150
Fix typos in librustdoc, tools and config files I used [`typos`](https://github.com/crate-ci/typos) to fix all typos, minus the ones present in rust-lang#110153 and in rust-lang#110154. Refs rust-lang#110150
Fix typos in compiler I ran [`typos -w compiler`](https://github.com/crate-ci/typos) to fix typos in the `compiler` directory. Refs rust-lang#110150
Fix typos in compiler I ran [`typos -w compiler`](https://github.com/crate-ci/typos) to fix typos in the `compiler` directory. Refs rust-lang#110150
Fix typos in library I ran [`typos -w library`](https://github.com/crate-ci/typos) to fix typos in the `library` directory. Refs rust-lang#110150
I ran
typos
to check for typos in this repo.The first 3 commits are mostly automatic changes from running
typos -w ./<dir>
, while the rest are fixes that I've manually applied.I have not included the config file because it's pretty ugly with a lot of manual exclusions but I can post it here if needed