Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add a runner for vanilla LLVM 16 #110242

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Apr 12, 2023

Like #107044, this will let us track compatibility with LLVM 16 going
forward, especially after we eventually upgrade our own to the next.

This also drops tidy here and in x86_64-gnu-llvm-15, syncing with
that change in #106085.

@rustbot
Copy link
Collaborator

rustbot commented Apr 12, 2023

r? @pietroalbini

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 12, 2023
@cuviper
Copy link
Member Author

cuviper commented Apr 12, 2023

This will need to coordinate with #110142 as well for the exact builder config.

@Mark-Simulacrum
Copy link
Member

Yeah. We'll want an 8 core builder here too, probably. Otherwise this looks fine to me, r=me.

@@ -11,7 +11,6 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
file \
curl \
ca-certificates \
python2.7 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both Dockerfiles have an outdated comment about how they use both Python 2 and 3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please use python2 in at least one of the test runners.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jyn514 mingw-check-tidy still uses it -- should be good enough?

# NOTE: intentionally uses python2 for x.py so we can test it still works.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we block on that in a full bors merge? I was under the impression it only ran on PRs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I suppose that is just a pr job. So, I can add something back to llvm-15 if you want, but the new llvm-16 builder is on ubuntu:23.04 which doesn't have python2 at all. Or we can find some other builder as the guinea pig, or maybe it's time to soft-retire python2 and stop worrying about it...

Copy link
Member

@jyn514 jyn514 Apr 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's find some other builder to be the guinea pig. I see src/ci/docker/host-x86_64/dist-x86_64-illumos/Dockerfile is using 18.04, would that work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we're barely testing python2 compat at all, given that x.py re-execs when it sees python3 available, but oh well. I've added it to dist-x86_64-illumos as suggested.

Like rust-lang#107044, this will let us track compatibility with LLVM 16 going
forward, especially after we eventually upgrade our own to the next.

This also drops `tidy` here and in `x86_64-gnu-llvm-15`, syncing with
that change in rust-lang#106085.
@cuviper
Copy link
Member Author

cuviper commented Apr 18, 2023

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Apr 18, 2023

📌 Commit 6fe2406 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2023
@bors
Copy link
Contributor

bors commented Apr 18, 2023

⌛ Testing commit 6fe2406 with merge 5fe3528...

@bors
Copy link
Contributor

bors commented Apr 18, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 5fe3528 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 18, 2023
@bors bors merged commit 5fe3528 into rust-lang:master Apr 18, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 18, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5fe3528): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.7% [0.8%, 2.8%] 4
Regressions ❌
(secondary)
6.4% [5.2%, 8.0%] 6
Improvements ✅
(primary)
-0.2% [-0.2%, -0.2%] 1
Improvements ✅
(secondary)
-0.6% [-0.6%, -0.6%] 3
All ❌✅ (primary) 1.3% [-0.2%, 2.8%] 5

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)
-4.0% [-6.4%, -1.6%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -4.0% [-6.4%, -1.6%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot added the perf-regression Performance regression. label Apr 18, 2023
@lqd
Copy link
Member

lqd commented Apr 18, 2023

Completely unrelated change. It's at least cool to see a list of some of the current benchmark noise.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Apr 18, 2023
@cuviper cuviper deleted the vanilla-llvm-16 branch May 21, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants