-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdarch: update submodule #110285
stdarch: update submodule #110285
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
r? @Amanieu |
@bors r+ |
⌛ Testing commit d5357c1 with merge 727db2d74e04267f48bbe758ac55ac05168bf4c3... |
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
@bors retry |
@KisaragiEffective: 🔑 Insufficient privileges: not in try users |
cc @lu-zero I think this failure may be due to your powerpc changes. |
This should be fixed by rust-lang/stdarch#1420. |
Somehow the notification did not hit my mailbox properly, sorry for the noise. |
@bors r+ |
⌛ Testing commit 1042b65 with merge faca88b6c23897bb1e9053125de3518858ed3837... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
The above test failure is related to rust-lang/stdarch#1407. Removing the following line should fix it. rust/library/std/tests/run-time-detect.rs Line 19 in f6830a2
|
You need to apply the change in #110285 (comment) to your PR otherwise the tests will not pass. |
It should be updated properly. |
No, you need to delete this line on the rust-lang/rust side: https://github.com/rust-lang/rust/blob/master/library/std/tests/run-time-detect.rs#L19 |
Oh, okay... |
please see rust-lang#110285 (comment) for more details
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (f7b831a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 659.045s -> 658.646s (-0.06%) |
please see rust-lang/rust#110285 (comment) for more details
We need this commit introduced by stdarch#1411 in order to merge #110189.
Note to myself:
git pull && git submodule update --remote library/stdarch