Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable needs_drop special-case for [T; 0] #110322

Closed
wants to merge 2 commits into from
Closed

disable needs_drop special-case for [T; 0] #110322

wants to merge 2 commits into from

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Apr 14, 2023 •
edited
Loading

#110288 (comment)

an alternative approach where we remove the special-case in needs_drop instead of also adding the special-case in dropck_outlives.

r? @RalfJung

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 14, 2023
@lcnr lcnr mentioned this pull request Apr 14, 2023
Closed
@lcnr lcnr marked this pull request as draft April 14, 2023 12:41
@RalfJung
Copy link
Member

This is way beyond me, I have no idea what the consequences of such a change are.^^

@SoniEx2
Copy link
Contributor

SoniEx2 commented Apr 14, 2023

[T; 0] is... sometimes used to force an alignment of T. We don't know much more than that tho. We'd expect a crater run to show regressions.

@lcnr
Copy link
Contributor Author

lcnr commented Apr 17, 2023

@bors try

@bors
Copy link
Contributor

bors commented Apr 17, 2023

⌛ Trying commit 9fb09b0 with merge 0818a9065516e3afb806892a26657c556d485386...

@bors
Copy link
Contributor

bors commented Apr 17, 2023

☀️ Try build successful - checks-actions
Build commit: 0818a9065516e3afb806892a26657c556d485386 (0818a9065516e3afb806892a26657c556d485386)

@lcnr
Copy link
Contributor Author

lcnr commented Apr 17, 2023

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-110322 created and queued.
🤖 Automatically detected try build 0818a9065516e3afb806892a26657c556d485386
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2023
@craterbot
Copy link
Collaborator

🚧 Experiment pr-110322 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-110322 is completed!
📊 546 regressed and 1 fixed (261734 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Apr 18, 2023
@lcnr
Copy link
Contributor Author

lcnr commented Apr 18, 2023

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-110322/retry-regressed-list.txt

@craterbot
Copy link
Collaborator

👌 Experiment pr-110322-1 created and queued.
🤖 Automatically detected try build 0818a9065516e3afb806892a26657c556d485386
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2023
@craterbot
Copy link
Collaborator

🚧 Experiment pr-110322-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-110322-1 is completed!
📊 457 regressed and 0 fixed (546 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Apr 18, 2023
@lcnr
Copy link
Contributor Author

lcnr commented Apr 18, 2023 •
edited
Loading

alright, there are quite a few valid regressions. Going with #110288 then

@lcnr lcnr closed this Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RalfJung RalfJung

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lcnr @RalfJung @SoniEx2 @bors @craterbot @rustbot