Track if EvalCtxt has been tainted, make sure it can't be used to make query responses after #110618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e query responses after
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
BoxyUwU
reviewed
Apr 20, 2023
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 21, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#110365 (ship tools with sysroot) - rust-lang#110555 (Substitute missing trait items suggestion correctly) - rust-lang#110578 (fix(error): normalize whitespace during msg_to_buffer) - rust-lang#110597 (remove unused ftl messages) - rust-lang#110611 (Add regression test for rust-lang#46506) - rust-lang#110618 (Track if EvalCtxt has been tainted, make sure it can't be used to make query responses after) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some additional protection against missing probes or strange candidate assembly behavior in the new solver.
For background, we don't ever want to call
evaluate_added_goals_and_make_canonical_responseif a previous call totry_evaluate_added_goalshas bailed withNoSolution, since our nested goals are left in an undefined state at that point. This most commonly suggests a missingEvalCtxt::probe, but could also signify some other shenanigans like dropping aQueryResulton the floor without properly?'ing it.r? @lcnr