Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More core::fmt::rt cleanup. #110766

Merged
merged 5 commits into from
Apr 28, 2023
Merged

More core::fmt::rt cleanup. #110766

merged 5 commits into from
Apr 28, 2023

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Apr 24, 2023 •
edited
Loading

  • Removes the V1 suffix from the Argument and Flag types.

  • Moves more of the format_args lang items into the core::fmt::rt module. (The only remaining lang item in core::fmt is Arguments itself, which is a public type.)

Part of #99012

Follow-up to #110616

m-ou-se added 3 commits April 24, 2023 16:16
@m-ou-se
Remove "V1" from ArgumentsV1 and FlagsV1.
5cf3cbf
@m-ou-se
Restructure std::fmt::rt a bit.
0a28977 
This moves more of the internal/lang items into the private rt module.
@m-ou-se
Update tests.
9cc5949
@m-ou-se m-ou-se added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-fmt Area: `core::fmt` labels Apr 24, 2023
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 24, 2023
@rustbot

This comment was marked as resolved.

Sign in to view
@m-ou-se m-ou-se mentioned this pull request Apr 24, 2023
Open
46 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 24, 2023

The Miri subtree was changed

cc @rust-lang/miri

@m-ou-se m-ou-se mentioned this pull request Apr 24, 2023
Merged
@m-ou-se
Copy link
Member Author

m-ou-se commented Apr 24, 2023

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 24, 2023
@m-ou-se m-ou-se mentioned this pull request Apr 24, 2023
Closed
jyn514
jyn514 approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me other than the two nits. All the items you moved had unstable(feature = "fmt_internals") so it seems fine to break the imports even though they were technically public before.

library/core/src/fmt/mod.rs Outdated Show resolved Hide resolved
library/core/src/fmt/rt.rs Outdated Show resolved Hide resolved
@jyn514
Copy link
Member

jyn514 commented Apr 27, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Apr 27, 2023

📌 Commit 52ff751 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 28, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2023
@bors
Auto merge of rust-lang#110924 - matthiaskrgr:rollup-jvznpq2, r=matth…
2fce229 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#110766 (More core::fmt::rt cleanup.)
 - rust-lang#110873 (Migrate trivially translatable `rustc_parse` diagnostics)
 - rust-lang#110904 (rustdoc: rebind bound vars to type-outlives predicates)
 - rust-lang#110913 (Add some missing built-in lints)
 - rust-lang#110918 (`remove_dir_all`: try deleting the directory even if `FILE_LIST_DIRECTORY` access is denied)
 - rust-lang#110920 (Fix unavailable url)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cf911ac into rust-lang:master Apr 28, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 28, 2023
@m-ou-se m-ou-se deleted the fmt-rt branch April 28, 2023 09:52
bors pushed a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2023
@matthiaskrgr
Rollup merge of rust-lang#110766 - m-ou-se:fmt-rt, r=jyn514
e99a990 
More core::fmt::rt cleanup.

- Removes the `V1` suffix from the `Argument` and `Flag` types.

- Moves more of the format_args lang items into the `core::fmt::rt` module. (The only remaining lang item in `core::fmt` is `Arguments` itself, which is a public type.)

Part of rust-lang#99012

Follow-up to rust-lang#110616
@tgross35 tgross35 mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 approved these changes

Assignees

@jyn514 jyn514

Labels
A-fmt Area: `core::fmt` C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
5 participants
@m-ou-se @rustbot @rust-log-analyzer @jyn514 @bors