-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Fix missing repr
attribute in doc(inline) on foreign items
#110901
Conversation
This encodes more attributes that may be quite common in some crates (like |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 3f08284 with merge df3a8d02aba793baba13db9147d6d76767cd0f0c... |
If the overhead is considered unacceptable, I'm pretty sure rustdoc can reconstitute the data using |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (df3a8d02aba793baba13db9147d6d76767cd0f0c): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Seems like the impact is small. \o/ |
@bors r+ |
@bors rollup=iffy |
…c, r=notriddle rustdoc: Fix missing `repr` attribute in doc(inline) on foreign items Fixes rust-lang#110698. r? `@notriddle`
⌛ Testing commit 3f08284 with merge 98578d8df50afc667038c6094532d00b4da58691... |
💔 Test failed - checks-actions |
@bors retry python setuptools issue |
☀️ Test successful - checks-actions |
Finished benchmarking commit (f495605): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Fixes #110698.
r? @notriddle