Don't duplicate anonymous lifetimes for async fn in traits #110965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
r=me if CI is green |
|
@bors r=cjgillot |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 29, 2023
… r=cjgillot Don't duplicate anonymous lifetimes for async fn in traits `record_lifetime_params_for_async` needs to be called outside of the scope of the function, or else it'll end up collecting anonymous lifetimes twice (those on the function and those within the `AnonymousCreateParameter` rib). This matches how `record_lifetime_params_for_async` is being used for functions with bodies below. This fixes (partially) rust-lang#110963 when the lifetimes are late-bound, but does not do so when the lifetimes are early-bound (as seen from the known-bug that I added).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 29, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#110614 (Clear response values for overflow in new solver) - rust-lang#110894 (Bump libffi-sys to 2.3.0) - rust-lang#110932 (include source error for LoadLibraryExW) - rust-lang#110958 (Make sure that some stdlib method signatures aren't accidental refinements) - rust-lang#110962 (Make drop_flags an IndexVec.) - rust-lang#110965 (Don't duplicate anonymous lifetimes for async fn in traits) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
record_lifetime_params_for_asyncneeds to be called outside of the scope of the function, or else it'll end up collecting anonymous lifetimes twice (those on the function and those within theAnonymousCreateParameterrib). This matches howrecord_lifetime_params_for_asyncis being used for functions with bodies below.This fixes (partially) #110963 when the lifetimes are late-bound, but does not do so when the lifetimes are early-bound (as seen from the known-bug that I added).