Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update wasi_clock_time_api ref. #110987

Merged
merged 1 commit into from
May 2, 2023
Merged

update wasi_clock_time_api ref. #110987

merged 1 commit into from
May 2, 2023

Conversation

infdahai
Copy link
Contributor

@infdahai infdahai commented Apr 29, 2023 •
edited
Loading

Closes #110809

Preview0 corresponded to the import module name wasi_unstable. It was also called snapshot_0 in some places. It was short-lived, and the changes to preview1 were minor, so the focus here is on preview1.

we use the preview1 doc according to the above quote form WASI legacy Readme .

@infdahai
update wasi_clock_time_api ref.
bca9387 
Signed-off-by: clundro <859287553@qq.com>
@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2023

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 29, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@m-ou-se
Copy link
Member

m-ou-se commented May 1, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 1, 2023

📌 Commit bca9387 has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request May 1, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 1, 2023
@bors
Auto merge of rust-lang#111066 - matthiaskrgr:rollup-4k6rj23, r=matth…
d6ddee6 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#109540 (std docs: edit `PathBuf::set_file_name` example)
 - rust-lang#110093 (Add 64-bit `time_t` support on 32-bit glibc Linux to `set_times`)
 - rust-lang#110987 (update wasi_clock_time_api ref.)
 - rust-lang#111038 (Leave promoteds untainted by errors when borrowck fails)
 - rust-lang#111042 (Add `#[no_coverage]` to the test harness's `fn main`)
 - rust-lang#111057 (Make sure the implementation of TcpStream::as_raw_fd is fully inlined)
 - rust-lang#111065 (Explicitly document how Send and Sync relate to references)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8a9e696 into rust-lang:master May 2, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 2, 2023
@infdahai infdahai deleted the wasi_clock_time branch May 2, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

__wasi_clock_time_get link is outdated
4 participants
@infdahai @rustbot @m-ou-se @bors