Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded function call in core::option. #111000

Merged
merged 1 commit into from
Apr 30, 2023
Merged

Remove unneeded function call in core::option. #111000

merged 1 commit into from
Apr 30, 2023

Conversation

JohnBobbo96
Copy link
Contributor

r? @jyn514

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 29, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@jyn514
Copy link
Member

jyn514 commented Apr 30, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Apr 30, 2023

📌 Commit a4f391d has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 30, 2023
Merged
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 30, 2023
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 30, 2023
@Dylan-DPC
Rollup merge of rust-lang#111000 - JohnBobbo96:core_option_unneeded_f…
71a5abe 
…unction, r=jyn514

Remove unneeded function call in `core::option`.

r? ``@jyn514``
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2023
@bors
Auto merge of rust-lang#111017 - matthiaskrgr:rollup-yy9updi, r=matth…
f2eb9f8 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#110118 (download-rustc: Give a better error message if artifacts can't be dowloaded)
 - rust-lang#110631 (rustdoc: catch and don't blow up on impl Trait cycles)
 - rust-lang#110732 (Make ConstProp some tests unit.)
 - rust-lang#110996 (bootstrap: Fix compile error: unused-mut)
 - rust-lang#110999 (Output some bootstrap messages on stderr)
 - rust-lang#111000 (Remove unneeded function call in `core::option`.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d8d24d4 into rust-lang:master Apr 30, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 30, 2023
@JohnBobbo96 JohnBobbo96 deleted the core_option_unneeded_function branch May 1, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jyn514 jyn514

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
4 participants
@JohnBobbo96 @rustbot @jyn514 @bors