Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test precise capture with a multi-variant enum and exhaustive patterns #111023

Merged
merged 1 commit into from
May 1, 2023
Merged

Test precise capture with a multi-variant enum and exhaustive patterns #111023

merged 1 commit into from
May 1, 2023

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Apr 30, 2023

Add test checking that it is possible to capture fields of a multi-variant enum, when remaining variants are visibly uninhabited (under the exhaustive_patterns feature gate).

@tmiasko
Test precise capture with a multi-variant enum and exhaustive patterns
b855308 
Add test checking that it is possible to capture fields of a
multi-variant enum, when remaining variants are visibly uninhabited
(under the `exhaustive_patterns` feature gate).
@rustbot
Copy link
Collaborator

rustbot commented Apr 30, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 30, 2023
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 30, 2023

📌 Commit b855308 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 30, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 1, 2023
@bors
Auto merge of rust-lang#111040 - matthiaskrgr:rollup-g2sns0f, r=matth…
2034b6d 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#110823 (Tweak await span to not contain dot)
 - rust-lang#111015 (Remove wrong assertion in match checking.)
 - rust-lang#111023 (Test precise capture with a multi-variant enum and exhaustive patterns)
 - rust-lang#111032 (Migrate `builtin_macros::asm` diagnostics to translatable diagnostics)
 - rust-lang#111033 (Ping Nadrieril when changing exhaustiveness checking)
 - rust-lang#111037 (Close parentheses for `offset_of` in AST pretty printing)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bde3cbd into rust-lang:master May 1, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 1, 2023
@tmiasko tmiasko deleted the multi-variant-capture branch May 1, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tmiasko @rustbot @compiler-errors @bors @davidtwco