Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boost iterator intersperse(_with) performance #111379

Merged
merged 5 commits into from
Jan 27, 2024
Merged

Boost iterator intersperse(_with) performance #111379

merged 5 commits into from
Jan 27, 2024

Commits on Jan 25, 2024

  1. Boost intersperse(_with) performance 

    I did some benchmark digging into the `intersperse` and `intersperse_with` code as part of the https://internals.rust-lang.org/t/add-iterate-with-separators-iterator-function/18781/13 discussion, and as a result I optimized them a bit, without relying on the peekable iterator.
    @nyurik
    nyurik committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    f9259d1 View commit details
    Browse the repository at this point in the history

  2. Postpone .next() call until iteration

    @nyurik
    nyurik committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    b8d245e View commit details
    Browse the repository at this point in the history

  3. fmt

    @nyurik
    nyurik committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    f1dbc7b View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Update library/core/src/iter/adapters/intersperse.rs 

    Co-authored-by: Josh Stone <cuviper@gmail.com>
    @nyurik @cuviper
    nyurik and cuviper authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    8cbff0b View commit details
    Browse the repository at this point in the history

  2. use checked_add for upper bound

    @nyurik
    nyurik committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    77f31ef View commit details
    Browse the repository at this point in the history