Rollup of 7 pull requests #111380

Dylan-DPC · 2023-05-09T07:03:48Z

Successful merges:

Add GNU Property Note #110304 (Add GNU Property Note)
Tweak borrow suggestion span #110504 (Tweak borrow suggestion span)
tweak "make mut" spans when assigning to locals #110583 (tweak "make mut" spans when assigning to locals)
Implement builtin # syntax and use it for offset_of!(...) #110694 (Implement builtin # syntax and use it for offset_of!(...))
Suggest let for possible binding with ty #111120 (Suggest let for possible binding with ty)
Min specialization improvements #111252 (Min specialization improvements)
Update books #111361 (Update books)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com>

Such implementations are usually mistakes and are not used in the compiler or standard library (after this commit) so forbid them with `min_specialization`.

Add an obligation cause for these error so that the error points to the implementations that caused the error.

We really shouldn't be naming functions `fn check_*` unless they're doing *typechecking*. It's especially misleading when we're doing this inside of HIR typeck.

Add GNU Property Note Fix rust-lang#103001 Generates the missing property note: ``` Displaying notes found in: .note.gnu.property Owner Data size Description GNU 0x00000010 NT_GNU_PROPERTY_TYPE_0 Properties: x86 feature: IBT ```

… r=cjgillot Tweak borrow suggestion span Avoids a `span_to_snippet` call when we don't need to surround the expression in parentheses. The fact that the suggestion was using the whole span of the expression rather than just appending a `&` was prevented me from using `// run-rustfix` in another PR (rust-lang#110432 (comment)). Also some drive-by renames of functions that have been annoying me for a bit.

…stebank tweak "make mut" spans when assigning to locals Work towards fixing rust-lang#106857 This PR just cleans up a lot of spans which is helpful before properly fixing the issues. Best reviewed commit-by-commit. r? `@estebank`

Implement builtin # syntax and use it for offset_of!(...) Add `builtin #` syntax to the parser, as well as a generic infrastructure to support both item and expression position builtin syntaxes. The PR also uses this infrastructure for the implementation of the `offset_of!` macro, added by rust-lang#106934. cc `@petrochenkov` `@DrMeepster` cc rust-lang#110680 `builtin #` tracking issue cc rust-lang#106655 `offset_of!` tracking issue

…ilstrieb Suggest let for possible binding with ty Origin from rust-lang#109128 (comment) r? `@Nilstrieb`

…s, r=compiler-errors Min specialization improvements - Don't allow specialization impls with no items, such implementations are probably not correct and only occur as mistakes in the compiler and standard library - Fix a missing normalization call - Adds spans for lifetime errors from overly general specializations Closes rust-lang#79457 Closes rust-lang#109815

Update books ## rust-lang/edition-guide 1 commits in 6038be9d37d7251c966b486154af621d1794d7af..f63e578b92ff43e8cc38fcaa257b660f45c8a8c2 2023-04-26 18:40:19 UTC to 2023-04-26 18:40:19 UTC - Fix grammar (rust-lang/edition-guide#281) ## rust-embedded/book 2 commits in 897fcf566f16bf87bf37199bdddec1801fd00532..d9eb4c3f75435b008881062ffa77bf0d1527b37d 2023-05-08 10:06:29 UTC to 2023-05-08 07:19:03 UTC - Update Interoperability section (rust-embedded/book#351) - Update c-with-rust.md (rust-embedded/book#352) ## rust-lang/reference 3 commits in 1f8dc727e94ae4ef92adf70df979521a1ea1143e..28dc0f3576b55f5e57c5d6e65cd68ba3161e9fd5 2023-05-06 20:25:36 UTC to 2023-05-05 01:51:00 UTC - Add an entry for macro_rules in the "Weak keywords" lexer block (rust-lang/reference#1356) - Document f16c target feature (rust-lang/reference#1337) - Fix example for non-x86 targets (rust-lang/reference#1334) ## rust-lang/rust-by-example 4 commits in 31961fe22521a779070a44a8f30a2b00a20b6212..8ee9528b72b927cff8fd32346db8bbd1198816f0 2023-05-01 21:18:34 UTC to 2023-04-25 11:19:41 UTC - add: zero padding example (rust-lang/rust-by-example#1706) - Update reenter_question_mark.md (rust-lang/rust-by-example#1705) - Clarify array out-of-bounds behavior. (rust-lang/rust-by-example#1703) - Update README.md (rust-lang/rust-by-example#1704) ## rust-lang/rustc-dev-guide 2 commits in 2a5eb92197e9cf8fe91164dcbf4f9b88c0d7e73d..28dbeaf5c44bc7f5111ad412e99f2d7c5cec6c90 2023-05-02 02:20:21 UTC to 2023-04-26 19:09:10 UTC - Add unset-exec-env compiletest header. (rust-lang/rustc-dev-guide#1682) - extend the sixth trait system requirement (rust-lang/rustc-dev-guide#1671)

Dylan-DPC · 2023-05-09T07:08:51Z

@bors r+ rollup=never p=5

bors · 2023-05-09T07:08:53Z

📌 Commit 9d913eb has been approved by Dylan-DPC

It is now in the queue for this repository.

bors · 2023-05-09T08:16:31Z

⌛ Testing commit 9d913eb with merge ecd3dba...

bors · 2023-05-09T11:07:27Z

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing ecd3dba to master...

rust-timer · 2023-05-09T11:09:28Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#111361	1bc35a1dd832c4a3bc2b17ba16ba51468da42e78
#111252	24c9ada191a2cd382dafa083fe928b0d3296aede
#111120	d034fdb50ccca95f3322cd419a6fc9ca00d97789
#110694	ff14a44ce4c5d04e57ffc830ac139e3edf6fcedf
#110583	50a5562bdfdf47c8d328b95875519371d57b81c1
#110504	b6424740202ed9792c1b70cf38b3227526dde94b
#110304	997215a1ae8f32265af31d0fd4571bdba6512d33

previous master: 7e7483d26e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-05-09T12:40:32Z

Finished benchmarking commit (ecd3dba): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	3
Regressions ❌ (secondary)	1.2%	[1.2%, 1.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.8%	[-0.8%, -0.8%]	1
All ❌✅ (primary)	1.1%	[1.1%, 1.1%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.7%	[2.3%, 4.8%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.0%, 0.2%]	33
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 656.5s -> 659.045s (0.39%)

Charisee and others added 30 commits April 22, 2023 01:00

Add GNU Property Note

cb4f815

tweak "make mut" spans when assigning to locals

fd8aa5e

tweak "make mut" spans (No. 2)

9624d2b

tweak "make mut" spans (No. 3)

57c6a31

tweak "make mut" spans (No. 4)

336a656

tweak spans for ref mut suggestion

87a1b38

implement review comment

d2608df

Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com>

fix trait definition spans in "make mut" suggestion

3e64e98

Disallow (min) specialization imps with no items

bd928a0

Such implementations are usually mistakes and are not used in the compiler or standard library (after this commit) so forbid them with `min_specialization`.

Normalize consistently for specializations

fafe9e7

Add GNU Property Note

68a5bb4

rewriting match on endianness

1fc0442

Add parsing for builtin # in expression and item context

59ecbd2

Migrate offset_of from a macro to builtin # syntax

5eb29c7

Add feature gate

83b4df4

rewriting match on endianness

37f3e2f

Report nicer lifetime errors for specialization

f46eabb

Add an obligation cause for these error so that the error points to the implementations that caused the error.

Suggest let for possible binding with ty

0bb43c6

cleanup

20e6e6a

fix ice in suggesting

a7fc32c

Tweak borrow suggestion

a9051d8

Rename some suggestion/note functions

a283f58

We really shouldn't be naming functions `fn check_*` unless they're doing *typechecking*. It's especially misleading when we're doing this inside of HIR typeck.

Make suggest_deref_or_ref return a multipart suggestion

4731a25

code refactor and fix wrong suggestion

5e94b5f

Update books

bf7e07f

move sugg to derive session diagnostic

4d219d0

Dylan-DPC added 3 commits May 9, 2023 12:33

Rollup merge of rust-lang#111120 - chenyukang:yukang-suggest-let, r=N…

8c51701

…ilstrieb Suggest let for possible binding with ty Origin from rust-lang#109128 (comment) r? `@Nilstrieb`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label May 9, 2023

bors merged commit ecd3dba into rust-lang:master May 9, 2023

rustbot added this to the 1.71.0 milestone May 9, 2023

bors mentioned this pull request May 9, 2023

[WIP] borrowck diagnostic migration with eager booted #104941

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 7 pull requests #111380

Rollup of 7 pull requests #111380

Dylan-DPC commented May 9, 2023

Dylan-DPC commented May 9, 2023

bors commented May 9, 2023

bors commented May 9, 2023

bors commented May 9, 2023

rust-timer commented May 9, 2023

rust-timer commented May 9, 2023

Rollup of 7 pull requests #111380

Rollup of 7 pull requests #111380

Conversation

Dylan-DPC commented May 9, 2023

Dylan-DPC commented May 9, 2023

bors commented May 9, 2023

bors commented May 9, 2023

bors commented May 9, 2023

rust-timer commented May 9, 2023

rust-timer commented May 9, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size